Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): use correct clair and builder-qemu tags #553

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

flavianmissi
Copy link
Contributor

@flavianmissi flavianmissi commented Oct 1, 2021

clair is in the process of removing their redhat-* branches, and asked
us to use their nightly instead.

I expected some builds to fail at first, but clair and builder-qemu are the exception - clair is removing their redhat-* branches, and the builder-qemu uses main instead of latest.
The rest of the expected tags will shortly be built manually so that we don't depend on pushes to our various redhat-3.5 branches.

Hope this makes sense, hit me up on slack otherwise.

clair is in the process of removing their redhat-* branches, and asked
us to use their nightly instead.
@flavianmissi flavianmissi changed the title fix: use clair nightly build fix(workflow): use correct clair and builder-qemu tags Oct 1, 2021
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@flavianmissi flavianmissi merged commit 78a3e0f into quay:master Oct 1, 2021
@flavianmissi flavianmissi deleted the build-use-clair-nightly branch October 1, 2021 15:40
flavianmissi added a commit to flavianmissi/quay-operator that referenced this pull request Oct 4, 2021
* fix: use clair nightly build

clair is in the process of removing their redhat-* branches, and asked
us to use their nightly instead.

also use correct tag for qemu builder image.
flavianmissi added a commit to flavianmissi/quay-operator that referenced this pull request Oct 4, 2021
* fix: use clair nightly build

clair is in the process of removing their redhat-* branches, and asked
us to use their nightly instead.

also use correct tag for qemu builder image.
flavianmissi added a commit that referenced this pull request Oct 5, 2021
* chore: github workflow to publish container images (PROJQUAY-2556) (#530)

* feat: setup e2e nightly run (PROJQUAY-2556) (#535)

* fix(workflow): use correct clair and builder-qemu tags (#553)

* fix: use clair nightly build

clair is in the process of removing their redhat-* branches, and asked
us to use their nightly instead.

also use correct tag for qemu builder image.

* fix(build): use bundle image digest instead of tag (PROJQUAY-2556) (#557)

and use env var to set it.
increase e2e timeout too, as 3 minutes ins't always enough for the mirror to get up and
running.

* refactor(build-workflow): infer image tag from branch name (PROJQUAY-2612) (#556)

This change ties the build workflow to the name of the branches it runs against.
In a future where downstream releases are fully (or nearly) automated, we should probably tag the redhat-* branches for everything we want built, alpha, release candidates, etc. When this is done, this workflow should be updated to get triggered when new tags are created.

* fix(build): add missed curly braces in expression (#559)

* fix: pull correct image on build workflow (PROJQUAY-2556) (#560)

* fix: use correct pull syntax on workflow (PROJQUAY-2556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants