Do not use endsWith on Path object for string comparison

[holly-cummins]

Resolves #46704.

I misunderstood how endsWith on a Path works; it only looks at whole path elements. As a result, a little 'optimisation' in #46625 broke tests in jars by causing the 'is this a jar?' branch to be bypassed.

We probably should have a test for this which catches the issue without needing to go to the JBeret ecosystem CI, but I'll add that separately, so that we can get this fix in ASAP.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 32de66c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[gsmet]

Ah ah, I got hit by that too a few months ago :).

[holly-cummins]

Ah ah, I got hit by that too a few months ago :).

I was so pleased with myself for making the code more efficient by avoiding an unnecessary toString() call. Then I was so annoyed with myself for not reading the Javadoc to confirm the method did what I thought it did. Glad it isn't just me who made that bad assumption!

[radcortez]

I confirm that it fixes the issue. Thank you :)