-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type safety of method signature #46625
Conversation
This comment has been minimized.
This comment has been minimized.
9bc3370
to
0eac0de
Compare
Status for workflow
|
Unfortunately, this change is causing an issue running the JBatch TCK: With:
|
Will have a look. I've raised #46704 to track. |
Thanks! I'll try to figure it out as well. |
I think I see the problem. Edit: Fixed in #46711 |
More minor adjustments, peeling unrelated changes out from #34681.
We convert the parameter for this method to a string before passing it in, but we can improve the expressiveness of the signature by passing in the Path.