Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type safety of method signature #46625

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Mar 5, 2025

More minor adjustments, peeling unrelated changes out from #34681.

We convert the parameter for this method to a string before passing it in, but we can improve the expressiveness of the signature by passing in the Path.

This comment has been minimized.

@holly-cummins holly-cummins force-pushed the tweak-method-signature branch from 9bc3370 to 0eac0de Compare March 5, 2025 09:23
Copy link

quarkus-bot bot commented Mar 5, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0eac0de.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/panache/hibernate-orm-rest-data-panache/deployment

io.quarkus.hibernate.orm.rest.data.panache.deployment.repository.PanacheRepositoryResourcePutMethodTest.shouldUpdateComplexObject - History

  • 1 expectation failed. JSON path name doesn't match. Expected: is "updated collection" Actual: empty collection - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path name doesn't match.
Expected: is "updated collection"
  Actual: empty collection

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)

@gsmet gsmet merged commit 50d31e2 into quarkusio:main Mar 5, 2025
58 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Mar 5, 2025
@radcortez
Copy link
Member

radcortez commented Mar 10, 2025

Unfortunately, this change is causing an issue running the JBatch TCK:
https://github.com/quarkiverse/quarkus-jberet/actions/runs/13757259497

With:

java.lang.RuntimeException: java.lang.IllegalStateException: Unable to translate path for /home/runner/.m2/repository/jakarta/batch/com.ibm.jbatch.tck/2.1.1/com.ibm.jbatch.tck-2.1.1.jar
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:611)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:706)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.IllegalStateException: Unable to translate path for /home/runner/.m2/repository/jakarta/batch/com.ibm.jbatch.tck/2.1.1/com.ibm.jbatch.tck-2.1.1.jar
	at io.quarkus.test.common.PathTestHelper.getAppClassLocationForTestLocation(PathTestHelper.java:225)
	at io.quarkus.test.junit.AbstractJvmQuarkusTestExtension.createAugmentor(AbstractJvmQuarkusTestExtension.java:137)
	at io.quarkus.test.junit.QuarkusTestExtension.doJavaStart(QuarkusTestExtension.java:190)
	at io.quarkus.test.junit.QuarkusTestExtension.ensureStarted(QuarkusTestExtension.java:578)
	at io.quarkus.test.junit.QuarkusTestExtension.beforeAll(QuarkusTestExtension.java:628)
	... 1 more

@holly-cummins
Copy link
Contributor Author

Will have a look. I've raised #46704 to track.

@radcortez
Copy link
Member

Thanks! I'll try to figure it out as well.

@holly-cummins
Copy link
Contributor Author

holly-cummins commented Mar 10, 2025

Thanks! I'll try to figure it out as well.

I think I see the problem.

Edit: Fixed in #46711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants