Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Security WebAuth guide to Hibernate ORM #38299

Conversation

michalvavrik
Copy link
Member

Copy link

github-actions bot commented Jan 19, 2024

🙈 The PR is closed and the preview is expired.

@FroMage FroMage changed the title Migrate Security WebAuth guide to Hiberante ORM Migrate Security WebAuth guide to Hibernate ORM Jan 19, 2024
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for the other PR, this is fine, but I wonder if we should not keep the reactive style for people who want to do reactive, as it's not trivial to turn the blocking one into the reactive one. People might not figure it out and give up 🤷

@sberyozkin
Copy link
Member

@michalvavrik Thanks, it probably closes a few other issues, give me 1 sec to check

@sberyozkin
Copy link
Member

@michalvavrik See #32376, looks like that issue is invalid ?

@michalvavrik
Copy link
Member Author

@michalvavrik See #32376, looks like that issue is invalid ?

IIRC codestarts work differently, I think the issue author confused terms. I can look into that issue, I'll put it on my list.

@michalvavrik
Copy link
Member Author

@FroMage I think it is not necessary to keep reactive guide as long as there is reactive quickstart, because they would be mostly duplicate. We can keep reactive quickstart and link it with this quickstart as well for those who use Hiberante Reactive.

I'll add the reactive quickstart as well and after that, I'll ask @sberyozkin to review changes (text that link Hibernate Reactive version). Thanks

@sberyozkin
Copy link
Member

Thanks @michalvavrik, let me merge given @FroMage's approval

@sberyozkin sberyozkin merged commit 1664dc2 into quarkusio:main Jan 19, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 19, 2024
@michalvavrik michalvavrik deleted the feature/migrate-webauth-guide-to-blocking-orm branch January 19, 2024 17:39
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Should security-web-authn guide and quickstart use Hibernate Reactive by default?
4 participants