-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Security WebAuth guide to Hibernate ORM #38299
Migrate Security WebAuth guide to Hibernate ORM #38299
Conversation
🙈 The PR is closed and the preview is expired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for the other PR, this is fine, but I wonder if we should not keep the reactive style for people who want to do reactive, as it's not trivial to turn the blocking one into the reactive one. People might not figure it out and give up 🤷
@michalvavrik Thanks, it probably closes a few other issues, give me 1 sec to check |
@michalvavrik See #32376, looks like that issue is invalid ? |
IIRC codestarts work differently, I think the issue author confused terms. I can look into that issue, I'll put it on my list. |
@FroMage I think it is not necessary to keep reactive guide as long as there is reactive quickstart, because they would be mostly duplicate. We can keep reactive quickstart and link it with this quickstart as well for those who use Hiberante Reactive. I'll add the reactive quickstart as well and after that, I'll ask @sberyozkin to review changes (text that link Hibernate Reactive version). Thanks |
Thanks @michalvavrik, let me merge given @FroMage's approval |
closes: #36438
related to quarkusio/quarkus-quickstarts#1375