-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Security WebAuthn quickstart from Hibernate Reactive to Hibernate ORM #1375
Migrate Security WebAuthn quickstart from Hibernate Reactive to Hibernate ORM #1375
Conversation
This comment has been minimized.
This comment has been minimized.
7f1db99
to
d6b8bba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but I do wonder if we should not have two quickstarts, because turning this into a reactive style is not trivial.
This comment has been minimized.
This comment has been minimized.
d6b8bba
to
bf501b6
Compare
I agree. Now - I kept the part you approved and added as copy & paste original quickstart (no code changes) as new module. The new module has postfix When this PR is merged, I'll link WebAuth guide with Reactive quickstart as well. Thanks for suggestion |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@sberyozkin I've added original quickstart as -reactive one, please take a look |
or @FroMage can re-check changes, I'll leave on whoever have little time :-) Quarkus PR is merged so we need to sync them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great!
Related to: quarkusio/quarkus#36438
Guide changes: quarkusio/quarkus#38299
Check list:
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md