Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Security WebAuthn quickstart from Hibernate Reactive to Hibernate ORM #1375

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jan 19, 2024

Related to: quarkusio/quarkus#36438

Guide changes: quarkusio/quarkus#38299

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/webauth-qs-use-blocking-hibernate branch from 7f1db99 to d6b8bba Compare January 19, 2024 14:18
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I do wonder if we should not have two quickstarts, because turning this into a reactive style is not trivial.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/webauth-qs-use-blocking-hibernate branch from d6b8bba to bf501b6 Compare January 19, 2024 17:57
@michalvavrik
Copy link
Member Author

This is fine, but I do wonder if we should not have two quickstarts, because turning this into a reactive style is not trivial.

I agree. Now - I kept the part you approved and added as copy & paste original quickstart (no code changes) as new module. The new module has postfix -reactive and its README says it is using Hibernate Reactive.

When this PR is merged, I'll link WebAuth guide with Reactive quickstart as well.

Thanks for suggestion

Copy link

quarkus-bot bot commented Jan 19, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@michalvavrik
Copy link
Member Author

@sberyozkin I've added original quickstart as -reactive one, please take a look

@michalvavrik
Copy link
Member Author

or @FroMage can re-check changes, I'll leave on whoever have little time :-) Quarkus PR is merged so we need to sync them.

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

@FroMage FroMage merged commit 4a73b0a into quarkusio:development Jan 22, 2024
2 checks passed
@michalvavrik michalvavrik deleted the feature/webauth-qs-use-blocking-hibernate branch January 22, 2024 15:37
@gsmet gsmet changed the title Migrate Security WebAuthn quickstart from Hibernate Reactive to Hibrenate ORM Migrate Security WebAuthn quickstart from Hibernate Reactive to Hibernate ORM Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants