Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow 1 message per second to slack servers #14

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gictor
Copy link

@gictor gictor commented Feb 15, 2017

No description provided.

@coveralls
Copy link

coveralls commented Feb 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 42e9349 on strossle:master into dc43448 on qualitybath:master.

@tikotzky
Copy link
Member

Thanks for PR.
A couple questions...

  1. Can you make this configurable? My app will send bursts of messages at more than 1 per second when errors occur and I haven't actually got rate limited in a long time.
  2. Are you able to submit the actual changes needed without updating formatting? It makes it hard to review when the entire file shows changed because formatting changes..

Thanks again.

@coveralls
Copy link

coveralls commented Feb 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f562632 on strossle:master into dc43448 on qualitybath:master.

@gictor
Copy link
Author

gictor commented Feb 16, 2017

Thanks for looking in to this @tikotzky. I think i got number 2 under control, indeed that was ugly. Concerning number one i could make it configurable if I have your word on you actually merging the pull request :).

As a side note, our issue is not the rate limit but this package crashing our applications JavaScript heap out of memory. My theory is that when things start failing, it start hogging sockets, that eats memory...

@tikotzky
Copy link
Member

no promises but if I can turn it off and/or decrease the timeout in my app I would merge 😄

regarding crashing your app... I'm running on heroku (with not that much ram) and haven't had that happen to us even in when large amounts of errors occurred, but i guess anything is possible...

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.3%) to 85.714% when pulling b5346ef on strossle:master into dc43448 on qualitybath:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-14.3%) to 85.714% when pulling b5346ef on strossle:master into dc43448 on qualitybath:master.

@coveralls
Copy link

coveralls commented Feb 17, 2017

Coverage Status

Coverage decreased (-14.3%) to 85.714% when pulling fbad154 on strossle:master into dc43448 on qualitybath:master.

@coveralls
Copy link

coveralls commented Feb 17, 2017

Coverage Status

Coverage decreased (-4.8%) to 95.238% when pulling 5433fbe on strossle:master into dc43448 on qualitybath:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 95.238% when pulling 6f6b6e6 on strossle:master into dc43448 on qualitybath:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 95.238% when pulling 6f6b6e6 on strossle:master into dc43448 on qualitybath:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 97.619% when pulling 144e220 on strossle:master into dc43448 on qualitybath:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 97.619% when pulling 144e220 on strossle:master into dc43448 on qualitybath:master.

@gictor
Copy link
Author

gictor commented Feb 22, 2017

Sorry for all the commits, does it look ok now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants