Skip to content

Commit

Permalink
Trying to increase test coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
gictor committed Feb 22, 2017
1 parent 6f6b6e6 commit 144e220
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 15 deletions.
26 changes: 11 additions & 15 deletions lib/bunyan-slack.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ var BunyanSlack = function (options, error) {

this.customFormatter = options.customFormatter;
this.webhook_url = options.webhook_url || options.webhookUrl;
this.error = error || function () {
};
this.error = error || function () {};
this.messageQueue = new CBuffer(10);

if (options.icon_url || options.iconUrl) {
Expand Down Expand Up @@ -53,21 +52,20 @@ var BunyanSlack = function (options, error) {
};

BunyanSlack.prototype.write = function write(record) {
var self = this,
levelName,
message;

if (typeof record === 'string') {
record = JSON.parse(record);
}
var self = this,
levelName,
message;

levelName = this.nameFromLevel[record.level];
if (typeof record === 'string') {
record = JSON.parse(record);
}

levelName = this.nameFromLevel[record.level];
try {
message = self.customFormatter ? self.customFormatter(record, levelName) : {
text: util.format('[%s] %s', levelName.toUpperCase(), record.msg)
};
} catch(err) {
} catch (err) {
return self.error(err);
}
var base = {
Expand All @@ -76,11 +74,9 @@ BunyanSlack.prototype.write = function write(record) {
icon_url: self.icon_url,
icon_emoji: self.icon_emoji
};

message = extend(base, message);

if(self.rate_limit_interval !== undefined) {
this.messageQueue.push(message);
self.messageQueue.push(message);
} else {
request.post({
url: self.webhook_url,
Expand All @@ -94,7 +90,7 @@ BunyanSlack.prototype.write = function write(record) {

BunyanSlack.prototype.intervalRunner = function intervalRunner() {
var self = this;
var message = this.messageQueue.pop();
var message = self.messageQueue.pop();
if(message !== undefined) {
request.post({
url: self.webhook_url,
Expand Down
10 changes: 10 additions & 0 deletions test/bunyan_slack_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,16 @@ describe('bunyan-slack', function() {
bs.intervalRunner();
expect(bs.messageQueue.pop()).to.equal(undefined);
});

it('should return a message on the queue', function () {
var bs = new BunyanSlack({
webhook_url: 'mywebhookurl',
rate_limit_interval: 1000
});
bs.write({ level: 60, msg: 'Hello Sir' });
expect(bs.messageQueue.pop().text).to.equal('[FATAL] Hello Sir');
});

});
});

Expand Down

0 comments on commit 144e220

Please sign in to comment.