Dactyl Manuform 5x6, 5x7, and 6x6: QMK Configurator fixes and partial code clean-up #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaced tabs with spaces (QMK convention) - aligned layout macro visually
- layout macro had the wrong name in info.json
- replaced tabs with spaces (QMK convention) - aligned layout macro visually
- corrected keyboard height - layout macro had the wrong name in info.json
- replaced tabs with spaces (QMK convention) - aligned layout macro visually
- layout macro had the wrong name in info.json
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Mar 7, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (76 commits) [Keyboard] Adds Gray Studio HB85 Initial Support (qmk#5311) [Keymap] Add KC_MAKE keycode to my userspace and keymaps (qmk#5324) [Keyboard] handwired/trackpoint: refactor and readme cleanup (qmk#5325) [Keyboard] re-arrange the pinout for backlight support (qmk#5321) [Keymap] update: simplify tapdance code for Minidox/keymaps/dustypomerleau (qmk#5315) [Keymap] Add vxid planck layout (qmk#5271) increase size of note counter variable to avoid overflow Adopted LAYOUT, added some keys (qmk#5320) Add more "decent" text editors (qmk#5308) Add DZ60 Tsangan Layout + Fn layer (qmk#5319) [Docs] Fix function signature (layer_state_set_*) (qmk#5313) Correct keyboard and layout dimensions for 40percent.club Foobar (qmk#5310) Dactyl Manuform 5x6, 5x7, and 6x6: QMK Configurator fixes and partial code clean-up (qmk#5307) Fixed default to dissable VIA (qmk#5309) Clean up debounce a bit (qmk#5255) Fix aanzee Configurator config file (qmk#5286) Separate keymaps to VIA enabled/dissabled. (qmk#5302) [Keymap] Add RGB config and controls to userspace (qmk#5299) Add LED Matrix to Features list for easy reference (qmk#5280) [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274) ...
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Mar 7, 2019
… code clean-up (qmk#5307) * Tidy up 5x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x6 - layout macro had the wrong name in info.json * Tidy up 5x7.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x7 - corrected keyboard height - layout macro had the wrong name in info.json * Tidy up 6x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 6x6 - layout macro had the wrong name in info.json
chie4hao
pushed a commit
to chie4hao/qmk_firmware
that referenced
this pull request
Mar 28, 2019
… code clean-up (qmk#5307) * Tidy up 5x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x6 - layout macro had the wrong name in info.json * Tidy up 5x7.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x7 - corrected keyboard height - layout macro had the wrong name in info.json * Tidy up 6x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 6x6 - layout macro had the wrong name in info.json
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 31, 2019
… code clean-up (qmk#5307) * Tidy up 5x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x6 - layout macro had the wrong name in info.json * Tidy up 5x7.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x7 - corrected keyboard height - layout macro had the wrong name in info.json * Tidy up 6x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 6x6 - layout macro had the wrong name in info.json
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Apr 3, 2019
… code clean-up (qmk#5307) * Tidy up 5x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x6 - layout macro had the wrong name in info.json * Tidy up 5x7.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x7 - corrected keyboard height - layout macro had the wrong name in info.json * Tidy up 6x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 6x6 - layout macro had the wrong name in info.json
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
… code clean-up (qmk#5307) * Tidy up 5x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x6 - layout macro had the wrong name in info.json * Tidy up 5x7.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x7 - corrected keyboard height - layout macro had the wrong name in info.json * Tidy up 6x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 6x6 - layout macro had the wrong name in info.json
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
… code clean-up (qmk#5307) * Tidy up 5x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x6 - layout macro had the wrong name in info.json * Tidy up 5x7.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 5x7 - corrected keyboard height - layout macro had the wrong name in info.json * Tidy up 6x6.h - replaced tabs with spaces (QMK convention) - aligned layout macro visually * Fix Configurator support for Dactyl Manuform 6x6 - layout macro had the wrong name in info.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Notes
This begins some clean-up tasks pertaining to the API and QMK Configurator. The checking was prompted by a report from @i5ar in #4098.
For reference:
Commit Log
Tidy up 5x6.h (7962e41)
Fix Configurator support for Dactyl Manuform 5x6 (a9a466c)
Tidy up 5x7.h (a8c9584)
Fix Configurator support for Dactyl Manuform 5x7 (3ef02b2)
Tidy up 6x6.h (d1d165b)
Fix Configurator support for Dactyl Manuform 6x6 (7156aa2)