Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vxid planck layout #5271

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Add vxid planck layout #5271

merged 1 commit into from
Mar 5, 2019

Conversation

mtreca
Copy link
Contributor

@mtreca mtreca commented Feb 28, 2019

Description

Add a custom planck layout

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flagged a couple of things.

These are entirely optional, but may be a good idea.

Either add the commits or let us know if you want it merged "as is". (either is fine).

@mtreca
Copy link
Contributor Author

mtreca commented Mar 5, 2019

@drashna @mechmerlin Thank you for the advice. I updated the keymap and rebased.
It is ready to merge now if it's okay for you.

Thanks!

@drashna
Copy link
Member

drashna commented Mar 5, 2019

Thanks!

@drashna drashna merged commit 2e8e465 into qmk:master Mar 5, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 7, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (76 commits)
  [Keyboard] Adds Gray Studio HB85 Initial Support (qmk#5311)
  [Keymap] Add KC_MAKE keycode to my userspace and keymaps (qmk#5324)
  [Keyboard] handwired/trackpoint: refactor and readme cleanup (qmk#5325)
  [Keyboard] re-arrange the pinout for backlight support (qmk#5321)
  [Keymap] update: simplify tapdance code for Minidox/keymaps/dustypomerleau (qmk#5315)
  [Keymap] Add vxid planck layout (qmk#5271)
  increase size of note counter variable to avoid overflow
  Adopted LAYOUT, added some keys (qmk#5320)
  Add more "decent" text editors (qmk#5308)
  Add DZ60 Tsangan Layout + Fn layer (qmk#5319)
  [Docs] Fix function signature (layer_state_set_*) (qmk#5313)
  Correct keyboard and layout dimensions for 40percent.club Foobar (qmk#5310)
  Dactyl Manuform 5x6, 5x7, and 6x6: QMK Configurator fixes and partial code clean-up (qmk#5307)
  Fixed default to dissable VIA (qmk#5309)
  Clean up debounce a bit (qmk#5255)
  Fix aanzee Configurator config file (qmk#5286)
  Separate keymaps to VIA enabled/dissabled. (qmk#5302)
  [Keymap] Add RGB config and controls to userspace (qmk#5299)
  Add LED Matrix to Features list for easy reference (qmk#5280)
  [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274)
  ...
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants