Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Numeric Keypad //e converter #5294

Merged
merged 6 commits into from
Mar 3, 2019
Merged

Adding Numeric Keypad //e converter #5294

merged 6 commits into from
Mar 3, 2019

Conversation

newbold
Copy link
Contributor

@newbold newbold commented Mar 3, 2019 •
edited
Loading

This is a new keyboard conversion for the Numeric Keypad //e, Apple's first non-integrated keyboard which happened to be a numpad for the Apple //e.

Description

Added keyboards/converter/numeric_keypad_IIe with everything needed to compile working QMK firmware on an ATmega32U4 microcontroller.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna drashna requested a review from mechmerlin March 3, 2019 01:06
noroadsleft
noroadsleft requested changes Mar 3, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of stylistic nitpicks (because I'm that guy), but otherwise LGTM. 👍

noroadsleft and others added 2 commits March 2, 2019 20:29
@noroadsleft @newbold
Update keyboards/converter/numeric_keypad_IIe/config.h
f2a30d9 
//e -> IIe

Co-Authored-By: newbold <[email protected]>
@noroadsleft @newbold
Update keyboards/converter/numeric_keypad_IIe/config.h
6c8e318 
//e -> IIe and wrapped description in quotes for comma inclusion

Co-Authored-By: newbold <[email protected]>
@newbold
Copy link
Contributor Author

newbold commented Mar 3, 2019

@noroadsleft Thanks, I committed both of those changes. Really appreciate the feedback!

@drashna
Copy link
Member

drashna commented Mar 3, 2019

Thanks!

@drashna drashna merged commit b5d85dd into qmk:master Mar 3, 2019
bl1nk added a commit to bl1nk/qmk_firmware that referenced this pull request Mar 3, 2019
@bl1nk
Merge remote-tracking branch 'upstream/master'
f82fe49 
* upstream/master: (58 commits)
  [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274)
  [Keyboard] matrix_init_user shouldn't call itself (qmk#5298)
  [Keymap] Update keymap.c (qmk#5290)
  Update Atreus layout to match the Niu layout. Fix Niu comment typo. (qmk#5297)
  [Keymap] Fix comment in the KBD67 default keymap. (qmk#5296)
  [Keyboard] update Hecomi/alpha's info.json  (qmk#5295)
  [Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
  [Keyboard] Add support for matrix_scan_user to usb-usb converter (qmk#5291)
  handwired/terminus_mini: refactor, Configurator support, and readme cleanup (qmk#5292)
  [Keyboard] Initial commit for Prime_E w/ VIA config support (qmk#5285)
  [Keyboard] add dz60rgb ansi and hhkb support; add dz40rgb (qmk#5231)
  [Keyboard] Convert mf68_ble to keymap (qmk#5287)
  [Keymap] Added INSERT to my keymaps (qmk#5284)
  HS60 v2: Instructions how to reset and flash (qmk#5241)
  [Keymap] unausgeschlafen quefrency keymap (qmk#5273)
  [Keymap] Fix rgblight_enable ifdefs (qmk#5283)
  [Keymap] DCompact Layout Updates pt. 3 (qmk#5209)
  [Keyboard] Add Dozen0 (qmk#5272)
  [Keymap] update: add extrakey support for macOS media keys (qmk#5263)
  [Keymap] My TMO50 layout (qmk#5116)
  ...
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
@newbold @slugger7
[Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
f6ffc80 
* Adding Numeric Keypad //e to conversions

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe

Co-Authored-By: newbold <[email protected]>

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe and wrapped description in quotes for comma inclusion

Co-Authored-By: newbold <[email protected]>

* Updating info.json for Configurator

* Corrected legend

* Update keyboards/converter/numeric_keypad_IIe/info.json

Corrected layout

Co-Authored-By: newbold <[email protected]>
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
@newbold @chie4hao
[Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
c445bf2 
* Adding Numeric Keypad //e to conversions

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe

Co-Authored-By: newbold <[email protected]>

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe and wrapped description in quotes for comma inclusion

Co-Authored-By: newbold <[email protected]>

* Updating info.json for Configurator

* Corrected legend

* Update keyboards/converter/numeric_keypad_IIe/info.json

Corrected layout

Co-Authored-By: newbold <[email protected]>
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
@newbold @zer09
[Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
c11ea3f 
* Adding Numeric Keypad //e to conversions

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe

Co-Authored-By: newbold <[email protected]>

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe and wrapped description in quotes for comma inclusion

Co-Authored-By: newbold <[email protected]>

* Updating info.json for Configurator

* Corrected legend

* Update keyboards/converter/numeric_keypad_IIe/info.json

Corrected layout

Co-Authored-By: newbold <[email protected]>
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
@newbold @slugger7
[Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
0feab32 
* Adding Numeric Keypad //e to conversions

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe

Co-Authored-By: newbold <[email protected]>

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe and wrapped description in quotes for comma inclusion

Co-Authored-By: newbold <[email protected]>

* Updating info.json for Configurator

* Corrected legend

* Update keyboards/converter/numeric_keypad_IIe/info.json

Corrected layout

Co-Authored-By: newbold <[email protected]>
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@newbold
[Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
00d4b98 
* Adding Numeric Keypad //e to conversions

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe

Co-Authored-By: newbold <[email protected]>

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe and wrapped description in quotes for comma inclusion

Co-Authored-By: newbold <[email protected]>

* Updating info.json for Configurator

* Corrected legend

* Update keyboards/converter/numeric_keypad_IIe/info.json

Corrected layout

Co-Authored-By: newbold <[email protected]>
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@newbold @Timbus
[Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
55cdb9c 
* Adding Numeric Keypad //e to conversions

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe

Co-Authored-By: newbold <[email protected]>

* Update keyboards/converter/numeric_keypad_IIe/config.h

//e -> IIe and wrapped description in quotes for comma inclusion

Co-Authored-By: newbold <[email protected]>

* Updating info.json for Configurator

* Corrected legend

* Update keyboards/converter/numeric_keypad_IIe/info.json

Corrected layout

Co-Authored-By: newbold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft requested changes

@drashna drashna drashna approved these changes

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newbold @drashna @noroadsleft