Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCompact Layout Updates pt. 3 #5209

Merged
merged 7 commits into from
Mar 1, 2019
Merged

DCompact Layout Updates pt. 3 #5209

merged 7 commits into from
Mar 1, 2019

Conversation

loksonarius
Copy link
Contributor

@loksonarius loksonarius commented Feb 22, 2019 •
edited
Loading

Description

  • Added implementation for existing DCompact layout to Levinson keyboard dir
  • Fixed README typos for DCompact layouts

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@loksonarius
Copy link
Contributor Author

I see some things have changed since I've last contributed. I've gone over the README and Contribution Guidelines, but please let me know if there's anything I've missed.

@noroadsleft
Copy link
Member

We haven't got this down "in writing" yet, but it's highly preferred to have all filenames fully in lowercase. (Windows gets stupid if you have README.md and readme.md in the same folder.)

If you could rename all the readme files as readme.md that would be swell.

@loksonarius
Copy link
Contributor Author

On it

@loksonarius
Copy link
Contributor Author

Dun @noroadsleft

@drashna drashna added the keymap label Feb 24, 2019
@loksonarius
Copy link
Contributor Author

Thank you both, suggestions accepted!

@drashna
Copy link
Member

drashna commented Mar 1, 2019

Looks great, thanks!

@drashna drashna merged commit 41d8be7 into qmk:master Mar 1, 2019
bl1nk added a commit to bl1nk/qmk_firmware that referenced this pull request Mar 3, 2019
@bl1nk
Merge remote-tracking branch 'upstream/master'
f82fe49 
* upstream/master: (58 commits)
  [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274)
  [Keyboard] matrix_init_user shouldn't call itself (qmk#5298)
  [Keymap] Update keymap.c (qmk#5290)
  Update Atreus layout to match the Niu layout. Fix Niu comment typo. (qmk#5297)
  [Keymap] Fix comment in the KBD67 default keymap. (qmk#5296)
  [Keyboard] update Hecomi/alpha's info.json  (qmk#5295)
  [Keyboard] Adding Numeric Keypad //e converter (qmk#5294)
  [Keyboard] Add support for matrix_scan_user to usb-usb converter (qmk#5291)
  handwired/terminus_mini: refactor, Configurator support, and readme cleanup (qmk#5292)
  [Keyboard] Initial commit for Prime_E w/ VIA config support (qmk#5285)
  [Keyboard] add dz60rgb ansi and hhkb support; add dz40rgb (qmk#5231)
  [Keyboard] Convert mf68_ble to keymap (qmk#5287)
  [Keymap] Added INSERT to my keymaps (qmk#5284)
  HS60 v2: Instructions how to reset and flash (qmk#5241)
  [Keymap] unausgeschlafen quefrency keymap (qmk#5273)
  [Keymap] Fix rgblight_enable ifdefs (qmk#5283)
  [Keymap] DCompact Layout Updates pt. 3 (qmk#5209)
  [Keyboard] Add Dozen0 (qmk#5272)
  [Keymap] update: add extrakey support for macOS media keys (qmk#5263)
  [Keymap] My TMO50 layout (qmk#5116)
  ...
@loksonarius loksonarius deleted the layout/dcompact-update-3 branch March 5, 2019 18:41
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
@loksonarius @slugger7
[Keymap] DCompact Layout Updates pt. 3 (qmk#5209)
669dbb2 
* Fix whitespace and Markdown errors

* Add DCompact layout implementation for Levinson keyboard

* Rename README.md to readme.md

* Rename README.md to readme.md

* Rename README.md to readme.md

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 18, 2019
@loksonarius @zer09
[Keymap] DCompact Layout Updates pt. 3 (qmk#5209)
e69de92 
* Fix whitespace and Markdown errors

* Add DCompact layout implementation for Levinson keyboard

* Rename README.md to readme.md

* Rename README.md to readme.md

* Rename README.md to readme.md

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
@loksonarius @chie4hao
[Keymap] DCompact Layout Updates pt. 3 (qmk#5209)
0a98761 
* Fix whitespace and Markdown errors

* Add DCompact layout implementation for Levinson keyboard

* Rename README.md to readme.md

* Rename README.md to readme.md

* Rename README.md to readme.md

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
@loksonarius @slugger7
[Keymap] DCompact Layout Updates pt. 3 (qmk#5209)
f9b6eec 
* Fix whitespace and Markdown errors

* Add DCompact layout implementation for Levinson keyboard

* Rename README.md to readme.md

* Rename README.md to readme.md

* Rename README.md to readme.md

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@loksonarius
[Keymap] DCompact Layout Updates pt. 3 (qmk#5209)
4e6e4fc 
* Fix whitespace and Markdown errors

* Add DCompact layout implementation for Levinson keyboard

* Rename README.md to readme.md

* Rename README.md to readme.md

* Rename README.md to readme.md

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>

* Update keyboards/keebio/levinson/keymaps/dcompact/keymap.c

Co-Authored-By: loksonarius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@noroadsleft noroadsleft noroadsleft requested changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loksonarius @noroadsleft @drashna