Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Adding buhearns keymap #5105

Merged
merged 11 commits into from
Feb 13, 2019
Merged

[Keymap] Adding buhearns keymap #5105

merged 11 commits into from
Feb 13, 2019

Conversation

buhearns
Copy link
Contributor

@buhearns buhearns commented Feb 11, 2019

Description

Adding buhearns personal keymap.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@buhearns
Copy link
Contributor Author

Thank you! Proposed changes have been implemented.

Everything working now with exception of the Euro sign (0x20AC) and Bullet (0x2022). Am I missing something? They should be within the normal Unicode range.

@drashna
Copy link
Member

drashna commented Feb 13, 2019

Odd that those unicode are not working. I'm not sure why. They should (and I have tested on my ergodox EZ).
€ and •

I can merge this now, or wait, just let me know what you'd like us to do.

@buhearns
Copy link
Contributor Author

Yes, please merge it. I am a bit busy the next few weeks but am planning to troubleshoot it sometime. It could very well be something on my end.

And thank you for taking the time, with the testing and all. Cheers!

@drashna
Copy link
Member

drashna commented Feb 13, 2019

Thanks!

@drashna drashna merged commit 918a52d into qmk:master Feb 13, 2019
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Feb 17, 2019
* master: (179 commits)
  Updates to noroadsleft keymap for KC60 (qmk#5127)
  [Keymap] Update to Drashna keymaps and Userspace  (qmk#5122)
  Fix ESC on Default ANSI layer (qmk#5125)
  [Keyboard] KBD19x Bootmagic Enable (lite) and other fixes (qmk#5126)
  [Keymap] Add fsck keymaps for eco, planck and preonic (qmk#5106)
  [Keyboard] Unigo66 beta pcb added, bug fixes for flashing (qmk#5108)
  [Keymap] Adding buhearns keymap (qmk#5105)
  [Keyboard] New Keyboard: Doro67 Regular PCB (qmk#5115)
  Add Satisfaction75 to QMK, Enable EEPROM on stm32f072 (qmk#5094)
  Fix travis_compiled_push.sh script issue (qmk#5114)
  [Keyboard] Added aeboards/aegis (qmk#5099)
  [Keyboard] Refactor jj4x4 to enable ortho_4x4 LAYOUT (qmk#5112)
  [Keyboard] Move Keebio boards to own folder (qmk#5109)
  [Keymap] Plain60 rgb (qmk#5104)
  [Keymap] Add Minidox keymap by dustypomerleau (qmk#5101)
  Remove AUTOGEN and fix Travis Compiled Push scripts (qmk#5077)
  Added WT75-A, refactor wilba.tech PCBs (qmk#5100)
  [Keyboard] Space65: RGB Animations on by default (qmk#5097)
  Add digital layout for KBD75 (qmk#5095)
  fix the led_matrix.h naming conflict
  ...
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* [Keymap] Adding buhearns keymap

* Removing deprecated function

with fauxpark's help

* Update readme.md

* Switching to UNICODE_ENABLE

with drashna's help

* Update rules.mk

* Update config.h

* Update config.h

Tidying up

* Update keymap.c

Tidying up

* Update readme.md

Tidying up

* Update rules.mk

Tidying up

* Removing GESC and adding TILD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants