Plain60 rgb #5104
Merged
Plain60 rgb #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Feb 12, 2019
|
Proposed changes have been integrated. Thank you for bringing up the deprecation of action_get_macro. I'll start using the new function from now on but decided to remove the macro from here all together since it isn't used anymore anyways. |
fauxpark
reviewed
Feb 12, 2019
| #define _LED 2 //LED configurations | ||
|
|
||
| //Keymapping renaming | ||
| #define ______ KC_TRNS //renaming KC_TRNS for readability in keymaps |
There was a problem hiding this comment.
If you remove this define and use the QMK-supplied one (which is 7 characters long), you can align your keymap much better.
drashna
approved these changes
Feb 13, 2019
tenderlove
added a commit
to tenderlove/qmk_firmware
that referenced
this pull request
Feb 17, 2019
* master: (179 commits) Updates to noroadsleft keymap for KC60 (qmk#5127) [Keymap] Update to Drashna keymaps and Userspace (qmk#5122) Fix ESC on Default ANSI layer (qmk#5125) [Keyboard] KBD19x Bootmagic Enable (lite) and other fixes (qmk#5126) [Keymap] Add fsck keymaps for eco, planck and preonic (qmk#5106) [Keyboard] Unigo66 beta pcb added, bug fixes for flashing (qmk#5108) [Keymap] Adding buhearns keymap (qmk#5105) [Keyboard] New Keyboard: Doro67 Regular PCB (qmk#5115) Add Satisfaction75 to QMK, Enable EEPROM on stm32f072 (qmk#5094) Fix travis_compiled_push.sh script issue (qmk#5114) [Keyboard] Added aeboards/aegis (qmk#5099) [Keyboard] Refactor jj4x4 to enable ortho_4x4 LAYOUT (qmk#5112) [Keyboard] Move Keebio boards to own folder (qmk#5109) [Keymap] Plain60 rgb (qmk#5104) [Keymap] Add Minidox keymap by dustypomerleau (qmk#5101) Remove AUTOGEN and fix Travis Compiled Push scripts (qmk#5077) Added WT75-A, refactor wilba.tech PCBs (qmk#5100) [Keyboard] Space65: RGB Animations on by default (qmk#5097) Add digital layout for KBD75 (qmk#5095) fix the led_matrix.h naming conflict ...
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Fix compile error if not used with VIA * Add keymap with support for RGB * Integrate changes from PR code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an error with the Plain60 PCB when compiling QMK without VIA support enabled and also adds a new RGB keymap as an example how to enable RGB for the board (if you have soldered a WS2812b strip to it)
Types of changes
Issues Fixed or Closed by this PR
Checklist: