Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard][S65-X] BACKLIGHT_CAPS_LOCK #4770

Merged
merged 1 commit into from
Jan 30, 2019
Merged

[Keyboard][S65-X] BACKLIGHT_CAPS_LOCK #4770

merged 1 commit into from
Jan 30, 2019

Conversation

Rockman18
Copy link
Contributor

@Rockman18 Rockman18 commented Jan 4, 2019 •
edited
Loading

Description

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

  • End of inconsistency between Caps Lock indicator and backlight state. There's was an inconsistency between backlight_config state and Caps Lock indicator so when toggling backlight sometime it doesn't turn off.
  • Keyboard backlight turns off when Host is suspended.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Rockman18 Rockman18 force-pushed the Keyboard-S65X-BACKLIGHT_CAPS_LOCK_INDICATOR branch from ab04093 to 9a1b70a Compare January 4, 2019 03:56
@drashna
Copy link
Member

drashna commented Jan 5, 2019

A lot of this could actually be handled by user code. Namely, led_set_user and https://docs.qmk.fm/#/custom_quantum_functions?id=keyboard-idlingwake-code

@Rockman18 Rockman18 force-pushed the Keyboard-S65X-BACKLIGHT_CAPS_LOCK_INDICATOR branch from 9a1b70a to d556047 Compare January 6, 2019 23:15
@Rockman18 Rockman18 changed the title Keyboard: S65-X - BACKLIGHT_CAPS_LOCK_INDICATOR Keyboard: S65-X - BACKLIGHT_CAPS_LOCK Jan 6, 2019
@Rockman18 Rockman18 force-pushed the Keyboard-S65X-BACKLIGHT_CAPS_LOCK_INDICATOR branch from d556047 to 454fd00 Compare January 6, 2019 23:16
@Rockman18 Rockman18 force-pushed the Keyboard-S65X-BACKLIGHT_CAPS_LOCK_INDICATOR branch 4 times, most recently from d6ed9f0 to 0cd9f5c Compare January 21, 2019 22:49
@vomindoraan
Copy link
Contributor

@drashna Could you mark this as "on hold" until #4769 (which this is based off of) is merged?

@Rockman18 Rockman18 force-pushed the Keyboard-S65X-BACKLIGHT_CAPS_LOCK_INDICATOR branch from 0cd9f5c to 75b7d43 Compare January 29, 2019 10:29
@Rockman18 Rockman18 changed the title Keyboard: S65-X - BACKLIGHT_CAPS_LOCK [Keyboard][S65-X] BACKLIGHT_CAPS_LOCK Jan 29, 2019
@Rockman18
[Keyboard][S65-X] BACKLIGHT_CAPS_LOCK
3d5df48 
Replace buggy Caps Lock indicator implementation with new
BACKLIGHT_CAPS_LOCK_INDICATOR feature.
@Rockman18 Rockman18 force-pushed the Keyboard-S65X-BACKLIGHT_CAPS_LOCK_INDICATOR branch from 75b7d43 to 3d5df48 Compare January 29, 2019 10:36
@Rockman18
Copy link
Contributor Author

@drashna @vomindoraan I rebase this to simplify the merge. Everything is OK...

@drashna drashna merged commit c2080d3 into qmk:master Jan 30, 2019
@Rockman18 Rockman18 deleted the Keyboard-S65X-BACKLIGHT_CAPS_LOCK_INDICATOR branch January 30, 2019 23:58
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jan 31, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
81e5bb1 
* 'master' of https://github.com/qmk/qmk_firmware: (43 commits)
  Remove duplicate make invocations
  Fix file size check for parallel make (qmk#5012)
  [Keyboard] 40percent.club's Half 'n' half keyboard port (qmk#5005)
  update canoe/readme (qmk#5014)
  [Keyboard][S65-X] BACKLIGHT_CAPS_LOCK (qmk#4770)
  space65-5001 init, small corrections to the total number of leds (qmk#5006)
  [Keyboard] add dz60rgb keyboard (qmk#4992)
  [Keyboard] Jj40 doc (qmk#4914)
  [Keyboard] Redox Wireless configurator bugfix (qmk#4961)
  added aanzee pcb support (qmk#4962)
  Sweet16 Keymap by Spaceman added (qmk#5003)
  [Keyboard] Gray Studio Directory (qmk#5002)
  Fix link and name spelling in Space65's readme (qmk#5004)
  [Keymap] Updates to ortho_4x12/buswerks keymap (qmk#4996)
  [Keyboard] Gray Studio Space 65 Support (qmk#5001)
  Moving cannonkeys boards to one place, eeprom fix (qmk#4999)
  convert to unix line-endings [skip ci]
  S60x Make Default standard layout and have separate Mac OS one (qmk#4964)
  [Keyboard] Bug Fix To Unigo66 (qmk#4995)
  Contribute the MechMerlin QMK Configurator docs (qmk#4986)
  ...
calmh added a commit to calmh/qmk_firmware that referenced this pull request Feb 4, 2019
@calmh
Merge branch 'master' into calmh
b089e46 
* master: (463 commits)
  New Keyboard: Sentraq Number Pad RGB DIY Kit (qmk#5047)
  ergodash Keyboard readme documentation (qmk#5046)
  [Keyboard] ADB converter lock LED fix (qmk#5035)
  [Keymap] Added , to fix errors (qmk#5034)
  Stanrc85 layout update/cleanup (qmk#5029)
  Add hand-swap config to Gergo layout (qmk#5033)
  [Keymap] Adds Preonic keymap for muzfuz. Small Planck addition. (qmk#5019)
  Change return type of layer_switch_get_layer() to uint8_t (qmk#5011)
  Space65 Updates (qmk#5008)
  [Keyboard] Add 1upkeyboards 1up80hte (Tsangan style PCB) (qmk#4988)
  Update info.json (qmk#5015)
  Fixed TGR Alice pinout and number of LEDs (qmk#5018)
  Generalized nyquist layout for 5x12 boards. Removed duplicate readme.md that was cased the same and caused issues.
  Remove duplicate make invocations
  Fix file size check for parallel make (qmk#5012)
  [Keyboard] 40percent.club's Half 'n' half keyboard port (qmk#5005)
  update canoe/readme (qmk#5014)
  [Keyboard][S65-X] BACKLIGHT_CAPS_LOCK (qmk#4770)
  space65-5001 init, small corrections to the total number of leds (qmk#5006)
  [Keyboard] add dz60rgb keyboard (qmk#4992)
  ...
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 9, 2019
@Rockman18 @zer09
[Keyboard][S65-X] BACKLIGHT_CAPS_LOCK (qmk#4770)
b706b21 
Replace buggy Caps Lock indicator implementation with new
BACKLIGHT_CAPS_LOCK_INDICATOR feature.
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@Rockman18
[Keyboard][S65-X] BACKLIGHT_CAPS_LOCK (qmk#4770)
d621a15 
Replace buggy Caps Lock indicator implementation with new
BACKLIGHT_CAPS_LOCK_INDICATOR feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rockman18 @drashna @vomindoraan @mechmerlin