Feature : Backlight - New option : BACKLIGHT_CAPS_LOCK #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rockman18
force-pushed
the
Feature-BACKLIGHT_CAPS_LOCK_INDICATOR
branch
from
b19e8bb to
f022a0d
Compare
13 tasks
Rockman18
force-pushed
the
Feature-BACKLIGHT_CAPS_LOCK_INDICATOR
branch
from
f022a0d to
62cce8f
Compare
drashna
requested review from
drashna,
skullydazed,
jackhumbert,
ezuk,
fredizzimo and
mechmerlin
drashna
approved these changes
Jan 5, 2019
Rockman18
changed the title
|
Hello @drashna, |
Rockman18
force-pushed
the
Feature-BACKLIGHT_CAPS_LOCK_INDICATOR
branch
2 times, most recently
from
38e2234 to
336bf48
Compare
I've implemented this feature because S65-X doesn't have LED indicators and the existing led_set_kb(usb_led) function try to use backlight as indicator but that creates an inconsistency with backlight_config state. - define `BACKLIGHT_CAPS_LOCK_INDICATOR` to enable Caps Lock indicator using backlight (for keyboards without dedicated LED) - Don't turn off LED indicators when suspend because backlight is already turned off. Else led_set(0) will turn back on backlight. - Documentation has been updated
…ps Lock if BACKLIGHT_CAPS_LOCK_INDICATOR
Rockman18
force-pushed
the
Feature-BACKLIGHT_CAPS_LOCK_INDICATOR
branch
from
4f482df to
8a55889
Compare
13 tasks
|
This feature would be quite useful to me. I haven't had the chance to test this on a real board yet, but at first glance the changes look okay (though I don't think I've considered all the edge cases). |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Feb 9, 2019
* [BACKLIGHT_CAPS_LOCK_INDICATOR] Use backlight toggling as Caps Lock LED I've implemented this feature because S65-X doesn't have LED indicators and the existing led_set_kb(usb_led) function try to use backlight as indicator but that creates an inconsistency with backlight_config state. - define `BACKLIGHT_CAPS_LOCK_INDICATOR` to enable Caps Lock indicator using backlight (for keyboards without dedicated LED) - Don't turn off LED indicators when suspend because backlight is already turned off. Else led_set(0) will turn back on backlight. - Documentation has been updated * [BACKLIGHT_CAPS_LOCK_INDICATOR] Turn off all LED indicators except Caps Lock if BACKLIGHT_CAPS_LOCK_INDICATOR * [BACKLIGHT_CAPS_LOCK] Rename BACKLIGHT_CAPS_LOCK_INDICATOR * [BACKLIGHT_CAPS_LOCK] Use new IS_LED_ON method
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* [BACKLIGHT_CAPS_LOCK_INDICATOR] Use backlight toggling as Caps Lock LED I've implemented this feature because S65-X doesn't have LED indicators and the existing led_set_kb(usb_led) function try to use backlight as indicator but that creates an inconsistency with backlight_config state. - define `BACKLIGHT_CAPS_LOCK_INDICATOR` to enable Caps Lock indicator using backlight (for keyboards without dedicated LED) - Don't turn off LED indicators when suspend because backlight is already turned off. Else led_set(0) will turn back on backlight. - Documentation has been updated * [BACKLIGHT_CAPS_LOCK_INDICATOR] Turn off all LED indicators except Caps Lock if BACKLIGHT_CAPS_LOCK_INDICATOR * [BACKLIGHT_CAPS_LOCK] Rename BACKLIGHT_CAPS_LOCK_INDICATOR * [BACKLIGHT_CAPS_LOCK] Use new IS_LED_ON method
|
Does anybody know why it's backward for me? The led is lit up when caps lock is off and led is turned off when caps lock is on? I've tried toggling caps locks with the keyboard unplugged and it consistently exhibits the same behavior |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've implemented this new option in backlight feature because my keyboard (S65-X) doesn't have LED indicators and the existing led_set_kb(usb_led) function try to use backlight as Caps Lock indicator but that creates an inconsistency with backlight_config state. Another bug, when suspending the power, the backlight stays on instead of turning off.
BACKLIGHT_CAPS_LOCKto enable Caps Lock indicator using backlight (for keyboards without dedicated LED). Default state : Not defined.Types of changes
Issues Fixed or Closed by this PR
Checklist: