Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Idobao Montex #13214

Merged
merged 30 commits into from
Jul 3, 2021
Merged

Add support for Idobao Montex #13214

merged 30 commits into from
Jul 3, 2021

Conversation

NachoxMacho
Copy link

@NachoxMacho NachoxMacho commented Jun 16, 2021 •
edited
Loading

Description

Add the new Idobao montex numpad keyboard. This is my first contribution to qmk so let me know if I'm missing something from the PR checklist/style guide.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Support for Montex

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@NachoxMacho NachoxMacho mentioned this pull request Jun 16, 2021
Closed
drashna
drashna requested changes Jun 17, 2021
View reviewed changes
NachoxMacho and others added 11 commits June 17, 2021 06:28
@NachoxMacho @drashna
Update keyboards/montex/keymaps/default/config.h
951e892 
Co-authored-by: Drashna Jaelre <[email protected]>
@NachoxMacho @drashna
Update keyboards/montex/keymaps/default/config.h
a1bb3f8 
Co-authored-by: Drashna Jaelre <[email protected]>
@NachoxMacho @drashna
Update keyboards/montex/keymaps/default/config.h
b535941 
Co-authored-by: Drashna Jaelre <[email protected]>
@NachoxMacho @drashna
Update keyboards/montex/rules.mk
daf9e83 
Co-authored-by: Drashna Jaelre <[email protected]>
@NachoxMacho
Add GPL licenses
de963d9
@NachoxMacho
Merge branch 'montex-keyboard' of https://github.com/NachoxMacho/qmk_…
b137125 
…firmware into montex-keyboard
@NachoxMacho
update default keymap reset combo to match factory default
43e4bdc
@NachoxMacho @drashna
Update keyboards/montex/montex.c
5f9cbaf 
Co-authored-by: Drashna Jaelre <[email protected]>
@NachoxMacho
Added bootloader instructions
5431963
@NachoxMacho
Merge branch 'montex-keyboard' of https://github.com/NachoxMacho/qmk_…
ab0bf39 
…firmware into montex-keyboard
@NachoxMacho
remove fluff from rules.mk
6f6460c
@NachoxMacho NachoxMacho requested a review from drashna June 17, 2021 11:49
@NachoxMacho
Copy link
Author

@drashna Is there anything more you need from me to merge this in?

@drashna drashna requested a review from a team June 20, 2021 02:12
fauxpark
fauxpark requested changes Jun 20, 2021
View reviewed changes
@NachoxMacho NachoxMacho requested a review from fauxpark June 20, 2021 14:31
fauxpark
fauxpark requested changes Jun 20, 2021
View reviewed changes
@NachoxMacho NachoxMacho requested a review from fauxpark June 20, 2021 15:30
@fauxpark fauxpark requested a review from a team June 20, 2021 15:32
noroadsleft
noroadsleft requested changes Jun 24, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NachoxMacho Have you compiled firmware from this code and flashed it to your Montex, and if so, does it work as expected?

There are apparent discrepancies between the QMK Configurator implementation and the submitted C source, and as I don't have this board and am not familiar with Idobao's boards in general, I can't say with certainty which "source of truth" is accurate.

@NachoxMacho
Copy link
Author

@NachoxMacho Have you compiled firmware from this code and flashed it to your Montex, and if so, does it work as expected?

There are apparent discrepancies between the QMK Configurator implementation and the submitted C source, and as I don't have this board and am not familiar with Idobao's boards in general, I can't say with certainty which "source of truth" is accurate.

Yes I have built and tested this code myself and it works. There was an issue of switched pins on the source JSON that idobao provided, but that has been fixed in this changset.

noroadsleft
noroadsleft requested changes Jun 26, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboards/montex/keymaps/default/config.h still needs to be moved two directories up the tree. Without this change, any keymap that isn't default will fail to compile.

@NachoxMacho NachoxMacho requested a review from noroadsleft June 26, 2021 14:09
@NachoxMacho
Copy link
Author

@noroadsleft I have made the changes requested. Please review again when you have a chance

@drashna
Copy link
Member

drashna commented Jul 3, 2021

Thanks!

@drashna drashna merged commit c55bb3d into qmk:master Jul 3, 2021
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
@NachoxMacho @drashna
@fauxpark @jakeprime
[Keyboard] Add support for Idobao Montex (qmk#13214)
b88dfd8 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@NachoxMacho @drashna
@fauxpark @HokieGeek
[Keyboard] Add support for Idobao Montex (qmk#13214)
1c51160 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@NachoxMacho @drashna
@fauxpark @wox
[Keyboard] Add support for Idobao Montex (qmk#13214)
7a8c699 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@NachoxMacho @drashna
@fauxpark @nhongooi
[Keyboard] Add support for Idobao Montex (qmk#13214)
2f69bef 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@NachoxMacho @drashna @fauxpark
[Keyboard] Add support for Idobao Montex (qmk#13214)
1ee74da 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NachoxMacho @drashna @fauxpark @noroadsleft