Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOLDEV-250] skip focus/active outlines for links inside buttons #746

Merged
merged 3 commits into from
Feb 2, 2023
Merged

[QOLDEV-250] skip focus/active outlines for links inside buttons #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef16e6f
[QOLDEV-250] skip focus/active outlines for links inside buttons
ThrawnCA Jan 30, 2023
ef19b3f
[QOLDEV-250] fix 'link inside button' stories
ThrawnCA Jan 31, 2023
275cced
Merge branch 'release-v4.1.0' of https://github.com/qld-gov-au/qg-web…
ThrawnCA Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/assets/_project/_blocks/components/link/_qg-link.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// &.hover {
// background: none;
// }
&:not(.btn-link) {
&:not(.btn-link, button a) {
&:active,
&:focus,
&:focus-visible,
Expand Down
6 changes: 6 additions & 0 deletions src/stories/components/Buttons/templates/States.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@
<button type="button" class="qg-btn btn-link active">btn-link</button>
<button type="button" class="qg-btn btn-link" disabled>btn-link</button>

<button type="button" class="qg-btn"><a>Link inside</a></button>
<button type="button" class="qg-btn hover"><a class="hover">Link inside</a></button>
<button type="button" class="qg-btn focus"><a class="focus">Link inside</a></button>
<button type="button" class="qg-btn active"><a class="active">Link inside</a></button>
<button type="button" class="qg-btn" disabled><a disabled>Link inside</a></button>