Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOLDEV-250] skip focus/active outlines for links inside buttons #746

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

ThrawnCA
Copy link
Contributor

  • The button will handle the outline, we don't want to double up

- The button will handle the outline, we don't want to double up
@RossWebsterWork
Copy link

The change seems good, but in the story, I noticed that the "Link inside" button's hover state doesn't match hovering over it's default case, where it still has blue text and an underline

- 'a' tags were overlooked for most stories
@ThrawnCA
Copy link
Contributor Author

The change seems good, but in the story, I noticed that the "Link inside" button's hover state doesn't match hovering over it's default case, where it still has blue text and an underline

Good catch, I messed up the story content (left out most of the 'a' tags). Should be resolved now.

@RossWebsterWork
Copy link

That's fixed the story links, although looking at it further, the hover effect only triggers when the inner text is hovered, and not the button itself (unlike btn-outline-dark and btn-link), including when the button is disabled.
Also the disabled btn-default visually reacts when clicked, and the btn-link is the only disabled button to not change the mouse to a hand (testing on Edge).

@ThrawnCA
Copy link
Contributor Author

ThrawnCA commented Feb 2, 2023

@RossWebsterWork Those seem like existing issues...Worth looking into at some point, but I'm still willing to merge this.

@ThrawnCA ThrawnCA merged commit 4d2309f into release-v4.1.0 Feb 2, 2023
@duttonw duttonw deleted the QOLDEV-250-accordion-double-outline branch July 5, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants