Remove unnecessary CSS files #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
stefan-woerner,
woodsp-ibm and
t-imamichi
as code owners
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
May 12, 2023
woodsp-ibm
added
stable backport potential
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
May 12, 2023
Pull Request Test Coverage Report for Build 4960719493
💛 - Coveralls |
|
Oops, I didn't realize this project was also using custom directives. Updated. |
t-imamichi
approved these changes
May 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2023
* Remove unnecessary CSS files * Also remove custom directives (cherry picked from commit bcaf93c)
t-imamichi
pushed a commit
that referenced
this pull request
May 15, 2023
* Remove unnecessary CSS files * Also remove custom directives (cherry picked from commit bcaf93c) Co-authored-by: Eric Arellano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one was using the custom directives
galleryitem,customgalleryitem,includenodoc,customcarditem.After removing this, it's safe to remove
sphinx-gallerybecause it's not used. That allows removinggallery.css, which is meant to overridesphinx-gallery's default styling.This also removes two CSS files:
custom.css: There is no.toggleelement anymorestyle.css: its 3 rules are holdovers from the Read The Docs themeCustomCalloutItemDirectiveis used though. It's used in a few other projects too, so I'm likely going to move this toqiskit_sphinx_themein its 1.13 release so that you don't have to copy and paste the code. Tracked by Qiskit/qiskit_sphinx_theme#323.