Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove css style that are specific to Sphinx-Gallery #164

Merged
merged 1 commit into from
May 12, 2023

Conversation

garrison
Copy link
Member

@garrison garrison added the documentation Improvements or additions to documentation label May 12, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4960266292

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.06%

Totals Coverage Status
Change from base Build 4959323286: 0.0%
Covered Lines: 2043
Relevant Lines: 2320

💛 - Coveralls

Comment on lines +1 to +4
/* Fix display of nbgallery with Sphinx default css */
.figure .caption .caption-text a.reference.internal {
border: 0;
}
Copy link
Member Author

@garrison garrison May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I can't convince myself that this css rule is still relevant for us. I added it deliberately for a good reason in e250cf8, but I can't remember why. It's not really hurting anything; we can always re-evaluate later.

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM thanks 👍

@garrison garrison merged commit da97d92 into main May 12, 2023
@garrison garrison deleted the rm-sphinx-gallery-css branch May 12, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants