Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update clients #758

Merged
merged 15 commits into from
Oct 5, 2024
Merged

chore: Update clients #758

merged 15 commits into from
Oct 5, 2024

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Aug 27, 2024

Updates clients with the latest dev changes.

For grpc I could not install grpcio==1.48.2, so I updated it with grpcio==1.49.1

New stuff:

  • facets
  • distance matrix
  • strict mode config
  • misc

@coszio coszio requested a review from joein August 27, 2024 16:08
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit ad89cb6
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/670050d0d0c75d0008324b27
😎 Deploy Preview https://deploy-preview-758--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein
Copy link
Member

joein commented Aug 29, 2024

@coszio

what was the problem with grpcio?
1.48.2 works fine for me

using 1.49.1 brings type checker issues :(

@coszio coszio force-pushed the update-clients branch 2 times, most recently from da86123 to 8abdfc5 Compare August 29, 2024 21:34
@coszio
Copy link
Contributor Author

coszio commented Aug 29, 2024

I believe what we need is to pin the grpcio-tools version to 1.48.2, but not necessarily for grpcio.

In my computer trying to build grpcio==1.48.2 fails every time, by relaxing this one, I could generate correctly, as far as I can tell

tools/generate_grpc_client.sh Outdated Show resolved Hide resolved
@joein joein self-requested a review September 3, 2024 05:49
joein
joein previously approved these changes Sep 3, 2024
@coszio coszio dismissed joein’s stale review September 3, 2024 18:41

Some bug was found

Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate grpc with original version of grpcio (yes, it requires older python)

Do not change the version.

coszio and others added 2 commits October 2, 2024 17:52
* facet in local_collection.py

* replace usages of calculate_payload_mask

* - qdrant remote
- qdrant base
- qdrant client
- conversions

* congruence tests + local mode fixes

* generate async client

* add type stubs and misc fixes

* fix mypy in Python 3.8

* generate async client

* review remarks

* gen async client

* update for bool facets
* add remote impls

* add client impl

* regen async client

* start local

* regen async

* local mode

* start congruence

* Fix local mode

* regen async of course

* test filtering

* fix min samples count

* simplify comparaison loop

* simplify samples loop

* add rest/gRPC conversion tests

* fix conversions + tests
@joein joein merged commit a6e2324 into dev Oct 5, 2024
14 checks passed
joein added a commit that referenced this pull request Oct 7, 2024
* update rest client

* update grpc client with grpcio 1.65.4

* update grpc client with grpcio==1.49.1

* generate grpc client with grpcio==1.48.2

* generate grpc client with grpcio==1.66.1 and mypy-protobuf extension

* add mypy-protobuf to pyproject

* relax version for grpcio, but keep grpcio-tools at 1.48.2

* improve generation script

* fix bash script comment

Co-authored-by: George <[email protected]>

* use old grpcio to generate client

* rollbakc mypy-protobuf

* regenerate with distance matrix

* new: update clients (#774)

* new: update clients

* rollback grpcio version

* feature: Facets (#759)

* facet in local_collection.py

* replace usages of calculate_payload_mask

* - qdrant remote
- qdrant base
- qdrant client
- conversions

* congruence tests + local mode fixes

* generate async client

* add type stubs and misc fixes

* fix mypy in Python 3.8

* generate async client

* review remarks

* gen async client

* update for bool facets

* Feature: Distance Matrix API (#769)

* add remote impls

* add client impl

* regen async client

* start local

* regen async

* local mode

* start congruence

* Fix local mode

* regen async of course

* test filtering

* fix min samples count

* simplify comparaison loop

* simplify samples loop

* add rest/gRPC conversion tests

* fix conversions + tests

---------

Co-authored-by: George <[email protected]>
Co-authored-by: generall <[email protected]>
Co-authored-by: Arnaud Gourlay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants