Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mypy-protobuf for better grpc type stubs #506

Closed
wants to merge 2 commits into from

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Feb 26, 2024

This adds mypy type stub generation for better DX with grpc types.

  • Adds mypy-protobuf to poetry dev dependencies
  • Adds --mypy_out flag to grpc client generator

dev:
image

PR:
image

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@coszio coszio requested a review from joein February 26, 2024 15:02
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 6b91b40
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/66d00000db2e2a0008e46e57
😎 Deploy Preview https://deploy-preview-506--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coszio coszio force-pushed the better-grpc-type-stubs branch from 26bcbe1 to 11a1b0b Compare March 4, 2024 13:31
@coszio
Copy link
Contributor Author

coszio commented Mar 4, 2024

Recreated the type stubs with the dev branch of qdrant core

@coszio
Copy link
Contributor Author

coszio commented Aug 28, 2024

@joein anything against this? Otherwise I think it makes our life easier

@joein
Copy link
Member

joein commented Aug 29, 2024

Let's merge it before 1.11.2, but not right now

@coszio
Copy link
Contributor Author

coszio commented Aug 29, 2024

I added the mypy stubs in #758, now that this one is approved. To not repeat client generation, I will close this one in favor of the other one.

@coszio coszio closed this Aug 29, 2024
@hh-space-invader hh-space-invader deleted the better-grpc-type-stubs branch September 25, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants