Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on github.com/360EntSecGroup-Skylar/excelize v1 #481

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Fix dependency on github.com/360EntSecGroup-Skylar/excelize v1 #481

merged 1 commit into from
Sep 14, 2019

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented Sep 13, 2019

PR Details

Fix issues related to v2 of the module. Test files import version one of the module so this is probably why people are reporting that this module has a dependency on v1.

Description

See above

Related Issue

#480

Motivation and Context

Module should not depend on itself and causes multiple versions of the module to be pulled in as dependencies.

How Has This Been Tested

go test

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          25       25           
  Lines        5258     5258           
=======================================
  Hits         5064     5064           
  Misses        109      109           
  Partials       85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbabcf...3c32741. Read the comment docs.

@xuri xuri merged commit a3ee098 into qax-os:master Sep 14, 2019
@bvwells
Copy link
Contributor Author

bvwells commented Sep 14, 2019

Thanks @xuri for the review!

@bvwells bvwells deleted the modules branch September 14, 2019 16:32
@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2020
nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
…/modules

Fix dependency on github.com/360EntSecGroup-Skylar/excelize v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants