Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module depends on v1 #480

Closed
bvwells opened this issue Sep 13, 2019 · 2 comments
Closed

Module depends on v1 #480

bvwells opened this issue Sep 13, 2019 · 2 comments

Comments

@bvwells
Copy link
Contributor

bvwells commented Sep 13, 2019

Description

This module depends on github.com/360EntSecGroup-Skylar/excelize v1 which is probably why people have reported issues with dependencies with both v1 and v2 appearing in their module files.

Steps to reproduce the issue:
Search for "github.com/360EntSecGroup-Skylar/excelize" within the code base.

Describe the results you received:
Dependencies on v1

Describe the results you expected:
Dependencies on v2 "github.com/360EntSecGroup-Skylar/excelize/v2".

Output of go version:
go version go1.12.9 windows/amd64

Excelize version or commit ID:
v2

Environment details (OS, Microsoft Excel™ version, physical, etc.):
Windows

@bvwells
Copy link
Contributor Author

bvwells commented Sep 13, 2019

This is probably related to issues #393

xuri added a commit that referenced this issue Sep 14, 2019
Fix dependency on github.com/360EntSecGroup-Skylar/excelize v1
@bvwells
Copy link
Contributor Author

bvwells commented Sep 14, 2019

Thanks @xuri for accepting the fix. Happy for this to be closed now.

@xuri xuri closed this as completed Sep 15, 2019
nullfy pushed a commit to nullfy/excelize that referenced this issue Oct 23, 2020
…/modules

Fix dependency on github.com/360EntSecGroup-Skylar/excelize v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants