Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for MNASNet #1224
Bugfix for MNASNet #1224
Changes from 42 commits
50bfbe6
e1c5506
0d77acc
c41aaab
d6115f9
568bd50
5617b8e
ba0ad4d
bd4836b
5ac43bd
102ba55
9c8b827
2872b1f
05b387b
2d39797
8b5f7b9
8de71fe
40471ac
b1d54ec
ec717d0
8b2dba9
06177ee
c34df87
8b538ae
7be7478
e996c36
1fc9c76
e5164e3
f5c9a17
1b7808e
96eb194
f50e776
0626a21
af9679d
c611d0d
ed89aac
36fa9fa
3ceed68
b9e60c2
2c8ccbc
9165032
061dade
d0a43c4
00ddb9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the initialization scheme, does this yield better performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may have very slightly improved the top1 on MNASNet b1 0.5 that I trained for this PR, but I'm not sure. The purpose of the change is that initialization is now identical to the reference TensorFlow code (which also uses a variance scaling initializer aka Kaiming uniform). Certainly not worse than before.