-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for MNASNet #1224
Merged
Merged
Bugfix for MNASNet #1224
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
50bfbe6
Add initial mnasnet impl
1e100 e1c5506
Remove all type hints, comply with PyTorch overall style
1e100 0d77acc
Expose models
1e100 c41aaab
Remove avgpool from features() and add separately
1e100 d6115f9
Merge upstream
1e100 568bd50
Fix python3-only stuff, replace subclasses with functions
1e100 5617b8e
fix __all__
1e100 ba0ad4d
Fix typo
1e100 bd4836b
Remove conditional dropout
1e100 5ac43bd
Merge branch 'master' of github.com:1e100/vision
1e100 102ba55
Make dropout functional
1e100 9c8b827
Addressing @fmassa's feedback, round 1
1e100 2872b1f
Replaced adaptive avgpool with mean on H and W to prevent collapsing …
1e100 05b387b
Partially address feedback
1e100 2d39797
YAPF
1e100 8b5f7b9
Removed redundant class vars
1e100 8de71fe
Merge master
1e100 40471ac
Update urls to releases
1e100 b1d54ec
Add information to models.rst
1e100 ec717d0
Replace init with kaiming_normal_ in fan-out mode
1e100 8b2dba9
Use load_state_dict_from_url
1e100 06177ee
Merge master
1e100 c34df87
Merge master again
1e100 8b538ae
Merge branch 'master' of https://github.com/pytorch/vision
1e100 7be7478
Fix depth scaling on first 2 layers
1e100 e996c36
Restore initialization
1e100 1fc9c76
Match reference implementation initialization for dense layer
1e100 e5164e3
Meant to use Kaiming
1e100 f5c9a17
Remove spurious relu
1e100 1b7808e
Point to the newest 0.5 checkpoint
1e100 96eb194
Latest pretrained checkpoint
1e100 f50e776
Merge branch 'master' of https://github.com/pytorch/vision
1e100 0626a21
Restore 1.0 checkpoint
1e100 af9679d
YAPF
1e100 c611d0d
Implement backwards compat as suggested by Soumith
1e100 ed89aac
Update checkpoint URL
1e100 36fa9fa
Move warnings up
1e100 3ceed68
Record a couple more function parameters
1e100 b9e60c2
Update comment
1e100 2c8ccbc
Set the correct version such that if the BC-patched model is saved, i…
1e100 9165032
Merge branch 'master' of github.com:1e100/vision
1e100 061dade
Set a member var, not class var
1e100 d0a43c4
Update mnasnet.py
1e100 00ddb9d
Update the path to weights
1e100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the initialization scheme, does this yield better performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may have very slightly improved the top1 on MNASNet b1 0.5 that I trained for this PR, but I'm not sure. The purpose of the change is that initialization is now identical to the reference TensorFlow code (which also uses a variance scaling initializer aka Kaiming uniform). Certainly not worse than before.