Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync constexpr irange patch from PyTorch core #8610

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Sync constexpr irange patch from PyTorch core #8610

wants to merge 6 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 21, 2025 •
edited
Loading

Specifically, pytorch/pytorch#147633 .

@swolchok
Update
accd815 
[ghstack-poisoned]
@swolchok
Update
c2644a4 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 21, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8610

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 52bfd0a with merge base 80d5e5a (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok mentioned this pull request Feb 21, 2025
Merged
swolchok added a commit that referenced this pull request Feb 21, 2025
@swolchok
Sync constexpr irange patch from PyTorch core
c60ea6d 
Specifically, pytorch/pytorch#147569 .

ghstack-source-id: 3e00b8e48069b57b9bcfc1d9f9b2bc64420eabef
ghstack-comment-id: 2673116689
Pull Request resolved: #8610
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@swolchok
Update
d0bc16e 
[ghstack-poisoned]
@swolchok
Update
5b2dec7 
[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Feb 21, 2025
Open
@swolchok
Update
609944a 
[ghstack-poisoned]
@swolchok
Update
52bfd0a 
[ghstack-poisoned]
Base automatically changed from gh/swolchok/276/head to main February 21, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@dbort dbort Awaiting requested review from dbort dbort is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @mergennachin @facebook-github-bot