Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "" from sys.path when running get-poetry.py #2380

Closed
wants to merge 9 commits into from

Conversation

dclong
Copy link

@dclong dclong commented May 3, 2020

Pull Request Check List

Resolves: #1304

  • Added tests for changed code.
  • Updated documentation for changed code.
    No documentation update needed.

@dclong dclong changed the title Installer sys path Remove "" from sys.path when running get-poetry.py May 3, 2020
@dclong dclong changed the title Remove "" from sys.path when running get-poetry.py Remove "" from sys.path when running get-poetry.py May 3, 2020
@dclong
Copy link
Author

dclong commented May 15, 2020

Can I get a review on this PR?

@finswimmer finswimmer requested a review from a team May 17, 2020 15:35
@abn
Copy link
Member

abn commented Mar 21, 2021

#3706 should replace get-poetry.py script. Maybe better for this to be a suggestion for the new bootstrap mechanism.

cc: @sdispater

@finswimmer
Copy link
Member

Hello @dclong,

thanks a lot for your contribution 👍

The get-poetry script is now deprecated in favor of the new install-poetry script. This is why I close your PR.

fin swimmer

@finswimmer finswimmer closed this Jun 22, 2021
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "" from sys.path in the Python script get-poetry.py
3 participants