Skip to content

Commit

Permalink
mypy type checks in password_manager (#5399)
Browse files Browse the repository at this point in the history
* Remove password_manager from mypy overrides in pyproject.toml

* mypy now passing on password_manager.py
  • Loading branch information
anthonymichaelclark authored Apr 1, 2022
1 parent 9b8d830 commit eb27f81
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ module = [
'poetry.utils.authenticator',
'poetry.utils.env',
'poetry.utils.exporter',
'poetry.utils.password_manager',
'poetry.utils.setup_reader',
]
ignore_errors = true
Expand Down
6 changes: 3 additions & 3 deletions src/poetry/utils/password_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ def _check(self) -> None:
class PasswordManager:
def __init__(self, config: Config) -> None:
self._config = config
self._keyring = None
self._keyring: KeyRing | None = None

@property
def keyring(self) -> KeyRing | None:
def keyring(self) -> KeyRing:
if self._keyring is None:
self._keyring = KeyRing("poetry-repository")
if not self._keyring.is_available():
Expand All @@ -140,7 +140,7 @@ def set_pypi_token(self, name: str, token: str) -> None:
else:
self.keyring.set_password(name, "__token__", token)

def get_pypi_token(self, name: str) -> str:
def get_pypi_token(self, name: str) -> str | None:
if not self.keyring.is_available():
return self._config.get(f"pypi-token.{name}")

Expand Down

0 comments on commit eb27f81

Please sign in to comment.