Skip to content

Commit

Permalink
chore(console): remove type errors (#5258)
Browse files Browse the repository at this point in the history
* chore(console/application): remove type errors

* chore(console/logging): remove type errors

* chore(utils/setup_reader): some fixes

* Revert "chore(utils/setup_reader): some fixes"

This reverts commit 9d82be9.
  • Loading branch information
eyllanesc authored Apr 1, 2022
1 parent 1732d4c commit 9b8d830
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ files = "src"

[[tool.mypy.overrides]]
module = [
'poetry.console.application',
'poetry.console.logging.formatters.builder_formatter',
'poetry.console.commands.init',
'poetry.inspection.info',
'poetry.installation.chef',
Expand Down
6 changes: 3 additions & 3 deletions src/poetry/console/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class Application(BaseApplication):
def __init__(self) -> None:
super().__init__("poetry", __version__)

self._poetry = None
self._poetry: Poetry | None = None
self._io: IO | None = None
self._disable_plugins = False
self._plugins_loaded = False
Expand Down Expand Up @@ -232,8 +232,8 @@ def register_command_loggers(
handler = IOHandler(io)
handler.setFormatter(IOFormatter())

for logger in loggers:
logger = logging.getLogger(logger)
for name in loggers:
logger = logging.getLogger(name)

logger.handlers = [handler]

Expand Down
8 changes: 1 addition & 7 deletions src/poetry/console/logging/formatters/formatter.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
from __future__ import annotations

from typing import TYPE_CHECKING


if TYPE_CHECKING:
import logging


class Formatter:
def format(self, record: logging.LogRecord) -> str:
def format(self, record: str) -> str:
raise NotImplementedError()

0 comments on commit 9b8d830

Please sign in to comment.