fix `reduce_by_python_constraint` #824

radoering · 2025-01-24T16:40:31Z

This fixes a bug that caused incorrect markers to be written into the lock file. See python-poetry/poetry-plugin-export#319.

Added tests for changed code.
Updated documentation for changed code.

Looks like I forgot that python_marker is special so that you cannot just use its constraint...

Summary by Sourcery

Bug Fixes:

Fix incorrect markers being written to the lock file when reducing markers by Python constraints.

This fixes a bug that caused incorrect markers to be written into the lock file. See poetry-plugin-export#319.

sourcery-ai · 2025-01-24T16:40:36Z

Reviewer's Guide by Sourcery

This pull request fixes a bug in the reduce_by_python_constraint function that caused incorrect markers to be written into the lock file. The fix ensures that the python_marker is correctly handled when reducing markers by a python constraint.

Sequence diagram for reduce_by_python_constraint marker handling

sequenceDiagram
    participant M as Marker
    participant R as reduce_by_python_constraint
    participant U as Utils

    M->>R: reduce_by_python_constraint(python_constraint)
    alt python version marker
        R->>U: get_python_constraint_from_marker(marker)
        U-->>R: constraint
        alt constraint allows all python_constraint
            R-->>M: AnyMarker()
        else constraint allows none of python_constraint
            R-->>M: EmptyMarker()
        else
            R-->>M: original marker
        end
    else
        R-->>M: original marker
    end

Class diagram for marker handling

classDiagram
    class BaseMarker {
        +reduce_by_python_constraint(python_constraint: VersionConstraint)
    }
    class SingleMarker {
        -name: str
        -constraint: VersionConstraint
        +reduce_by_python_constraint(python_constraint: VersionConstraint)
    }
    class MultiMarker {
        -markers: List[BaseMarker]
        +reduce_by_python_constraint(python_constraint: VersionConstraint)
    }
    class AnyMarker {
    }
    class EmptyMarker {
    }

    BaseMarker <|-- SingleMarker
    BaseMarker <|-- MultiMarker
    BaseMarker <|-- AnyMarker
    BaseMarker <|-- EmptyMarker

    note for SingleMarker "Fixed to use get_python_constraint_from_marker"
    note for MultiMarker "Updated to handle VersionRange"

File-Level Changes

Change	Details	Files
Correctly handle `python_marker` when reducing markers by a python constraint.	Use `get_python_constraint_from_marker` to get the correct constraint from the marker. Check if the constraint allows all or any of the python constraint.	`src/poetry/core/version/markers.py`
Add test cases for `reduce_by_python_constraint`.	Add test cases for `python_version` and `python_full_version` markers. Add test cases for complex markers with `or` and `and` operators.	`tests/version/test_markers.py`
Handle `VersionRange` and `VersionUnion` types in `reduce_by_python_constraint`.	Check if the `python_constraint` is an instance of `VersionRange` or `VersionUnion`.	`src/poetry/core/version/markers.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

Please add documentation describing the fix and expected behavior for Python version constraint handling in markers. This will help users understand how version constraints are processed, especially since this fixes a bug in lock file generation.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [poetry](https://github.com/python-poetry/poetry) ([changelog](https://python-poetry.org/history/)) | major | `1.8.5` -> `2.1.0` | --- ### Release Notes <details> <summary>python-poetry/poetry (poetry)</summary> ### [`v2.1.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#210---2025-02-15) [Compare Source](python-poetry/poetry@2.0.1...2.1.0) ##### Added - **Make `build` command build-system agnostic** ([#10059](python-poetry/poetry#10059), [#10092](python-poetry/poetry#10092)). - Add a `--config-settings` option to `poetry build` ([#10059](python-poetry/poetry#10059)). - Add support for defining `config-settings` when building dependencies ([#10129](python-poetry/poetry#10129)). - **Add (experimental) commands to manage Python installations** ([#10112](python-poetry/poetry#10112)). - Use `findpython` to find the Python interpreters ([#10097](python-poetry/poetry#10097)). - Add a `--no-truncate` option to `poetry show` ([#9580](python-poetry/poetry#9580)). - Re-add support for passwords with empty usernames ([#10088](python-poetry/poetry#10088)). - Add better error messages ([#10053](python-poetry/poetry#10053), [#10065](python-poetry/poetry#10065), [#10126](python-poetry/poetry#10126), [#10127](python-poetry/poetry#10127), [#10132](python-poetry/poetry#10132)). ##### Changed - **`poetry new` defaults to "src" layout by default** ([#10135](python-poetry/poetry#10135)). - Improve performance of locking dependencies ([#10111](python-poetry/poetry#10111), [#10114](python-poetry/poetry#10114), [#10138](python-poetry/poetry#10138), [#10146](python-poetry/poetry#10146)). - Deprecate adding sources without specifying `--priority` ([#10134](python-poetry/poetry#10134)). ##### Fixed - Fix an issue where global options were not handled correctly when positioned after command options ([#10021](python-poetry/poetry#10021), [#10067](python-poetry/poetry#10067), [#10128](python-poetry/poetry#10128)). - Fix an issue where building a dependency from source failed because of a conflict between build-system dependencies that were not required for the target environment ([#10048](python-poetry/poetry#10048)). - Fix an issue where `poetry init` was not able to find a package on PyPI while adding dependencies interactively ([#10055](python-poetry/poetry#10055)). - Fix an issue where the `@latest` descriptor was incorrectly passed to the core requirement parser ([#10069](python-poetry/poetry#10069)). - Fix an issue where Boolean environment variables set to `True` (in contrast to `true`) were interpreted as `false` ([#10080](python-poetry/poetry#10080)). - Fix an issue where `poetry env activate` reported a misleading error message ([#10087](python-poetry/poetry#10087)). - Fix an issue where adding an optional dependency with `poetry add --optional` would not correctly update the lock file ([#10076](python-poetry/poetry#10076)). - Fix an issue where `pip` was not installed/updated before other dependencies resulting in a race condition ([#10102](python-poetry/poetry#10102)). - Fix an issue where Poetry freezes when multiple threads attempt to unlock the `keyring` simultaneously ([#10062](python-poetry/poetry#10062)). - Fix an issue where markers with extras were not locked correctly ([#10119](python-poetry/poetry#10119)). - Fix an issue where self-referential extras were not resolved correctly ([#10106](python-poetry/poetry#10106)). - Fix an issue where Poetry could not be run from a `zipapp` ([#10074](python-poetry/poetry#10074)). - Fix an issue where installation failed with a permission error when using the system environment as a user without write access to system site packages ([#9014](python-poetry/poetry#9014)). - Fix an issue where a version of a dependency that is not compatible with the project's python constraint was locked. ([#10141](python-poetry/poetry#10141)). - Fix an issue where Poetry wrongly reported that the current project's supported Python range is not compatible with some of the required packages Python requirement ([#10157](python-poetry/poetry#10157)). - Fix an issue where the requested extras of a dependency were ignored if the same dependency (with same extras) was specified in multiple groups ([#10158](python-poetry/poetry#10158)). ##### Docs - Sort commands by name in the CLI reference ([#10035](python-poetry/poetry#10035)). - Add missing documentation for `env` commands ([#10027](python-poetry/poetry#10027)). - Clarify that the `name` and `version` fields are always required if the `project` section is specified ([#10033](python-poetry/poetry#10033)). - Add a note about restarting the shell for tab completion changes to take effect ([#10070](python-poetry/poetry#10070)). - Fix the example for `project.gui-scripts` [#10121](python-poetry/poetry#10121). - Explain how to include files as scripts in the project configuration ([#9572](python-poetry/poetry#9572), [#10133](python-poetry/poetry#10133)). - Add additional information on specifying required python versions ([#10104](python-poetry/poetry#10104)). ##### poetry-core ([`2.1.0`](https://github.com/python-poetry/poetry-core/releases/tag/2.1.0)) - Fix an issue where inclusive ordering with post releases was inconsistent with PEP 440 ([#379](python-poetry/poetry-core#379)). - Fix an issue where invalid URI tokens in PEP 508 requirement strings were silently discarded ([#817](python-poetry/poetry-core#817)). - Fix an issue where wrong markers were calculated when removing parts covered by the project's python constraint ([#824](python-poetry/poetry-core#824)). - Fix an issue where optional dependencies that are not part of an extra were included in the wheel metadata ([#830](python-poetry/poetry-core#830)). - Fix an issue where the `__pycache__` directory and `*.pyc` files were included in sdists and wheels ([#835](python-poetry/poetry-core#835)). ### [`v2.0.1`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#201---2025-01-11) [Compare Source](python-poetry/poetry@2.0.0...2.0.1) ##### Added - Add support for `poetry search` in legacy sources ([#9949](python-poetry/poetry#9949)). - Add a message in the `poetry source show` output when PyPI is implicitly enabled ([#9974](python-poetry/poetry#9974)). ##### Changed - Improve performance for merging markers from overrides at the end of dependency resolution ([#10018](python-poetry/poetry#10018)). ##### Fixed - Fix an issue where `poetry sync` did not remove packages that were not requested ([#9946](python-poetry/poetry#9946)). - Fix an issue where `poetry check` failed even though there were just warnings and add a `--strict` option to fail on warnings ([#9983](python-poetry/poetry#9983)). - Fix an issue where `poetry update`, `poetry add` and `poetry remove` with `--only` uninstalled packages from other groups ([#10014](python-poetry/poetry#10014)). - Fix an issue where `poetry update`, `poetry add` and `poetry remove` uninstalled all extra packages ([#10016](python-poetry/poetry#10016)). - Fix an issue where `poetry self update` did not recognize Poetry's own environment ([#9995](python-poetry/poetry#9995)). - Fix an issue where read-only system site-packages were not considered when loading an environment with system site-packages ([#9942](python-poetry/poetry#9942)). - Fix an issue where an error message in `poetry install` started with `Warning:` instead of `Error:` ([#9945](python-poetry/poetry#9945)). - Fix an issue where `Command.set_poetry`, which is used by plugins, was removed ([#9981](python-poetry/poetry#9981)). - Fix an issue where the help text of `poetry build --clean` showed a malformed short option instead of the description ([#9994](python-poetry/poetry#9994)). ##### Docs - Add a FAQ entry for the migration from Poetry-specific fields to the `project` section ([#9996](python-poetry/poetry#9996)). - Fix examples for `project.readme` and `project.urls` ([#9948](python-poetry/poetry#9948)). - Add a warning that package sources are a Poetry-specific feature that is not included in core metadata ([#9935](python-poetry/poetry#9935)). - Replace `poetry install --sync` with `poetry sync` in the section about synchronizing dependencies ([#9944](python-poetry/poetry#9944)). - Replace `poetry shell` with `poetry env activate` in the basic usage section ([#9963](python-poetry/poetry#9963)). - Mention that `project.name` is always required when the `project` section is used ([#9989](python-poetry/poetry#9989)). - Fix the constraint of `poetry-plugin-export` in the section about `poetry export` ([#9954](python-poetry/poetry#9954)). ##### poetry-core ([`2.0.1`](https://github.com/python-poetry/poetry-core/releases/tag/2.0.1)) - Replace the deprecated core metadata field `Home-page` with `Project-URL: Homepage` ([#807](python-poetry/poetry-core#807)). - Fix an issue where includes from `tool.poetry.packages` without a specified `format` were not initialized with the default value resulting in a `KeyError` ([#805](python-poetry/poetry-core#805)). - Fix an issue where some `project.urls` entries were not processed correctly resulting in a `KeyError` ([#807](python-poetry/poetry-core#807)). - Fix an issue where dynamic `project.dependencies` via `tool.poetry.dependencies` were ignored if `project.optional-dependencies` were defined ([#811](python-poetry/poetry-core#811)). ### [`v2.0.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#200---2025-01-05) [Compare Source](python-poetry/poetry@1.8.5...2.0.0) ##### Added - **Add support for the `project` section in the `pyproject.toml` file according to PEP 621** ([#9135](python-poetry/poetry#9135), [#9917](python-poetry/poetry#9917)). - **Add support for defining Poetry plugins that are required by the project and automatically installed if not present** ([#9547](python-poetry/poetry#9547)). - **Lock resulting markers and groups and add a `installer.re-resolve` option (default: `true`) to allow installation without re-resolving** ([#9427](python-poetry/poetry#9427)). - Add a `--local-version` option to `poetry build` ([#9064](python-poetry/poetry#9064)). - Add a `--clean` option to `poetry build` ([#9067](python-poetry/poetry#9067)). - Add FIPS support for `poetry publish` ([#9101](python-poetry/poetry#9101)). - Add the option to use `poetry new` interactively and configure more fields ([#9101](python-poetry/poetry#9101)). - Add a config option `installer.only-binary` to enforce the use of binary distribution formats ([#9150](python-poetry/poetry#9150)). - Add backend support for legacy repository search ([#9132](python-poetry/poetry#9132)). - Add support to resume downloads from connection resets ([#9422](python-poetry/poetry#9422)). - Add the option to define a constraint for the required Poetry version to manage the project ([#9547](python-poetry/poetry#9547)). - Add an `--all-groups` option to `poetry install` ([#9744](python-poetry/poetry#9744)). - Add an `poetry env activate` command as replacement of `poetry shell` ([#9763](python-poetry/poetry#9763)). - Add a `--markers` option to `poetry add` to add a dependency with markers ([#9814](python-poetry/poetry#9814)). - Add a `--migrate` option to `poetry config` to migrate outdated configs ([#9830](python-poetry/poetry#9830)). - Add a `--project` option to search the `pyproject.toml` file in another directory without switching the directory ([#9831](python-poetry/poetry#9831)). - Add support for shortened hashes to define git dependencies ([#9748](python-poetry/poetry#9748)). - Add partial support for conflicting extras ([#9553](python-poetry/poetry#9553)). - Add a `poetry sync` command as replacement of `poetry install --sync` ([#9801](python-poetry/poetry#9801)). ##### Changed - **Change the default behavior of `poetry lock` to `--no-update` and introduce a `--regenerate` option for the old default behavior** ([#9327](python-poetry/poetry#9327)). - **Remove the dependency on `poetry-plugin-export` so that `poetry export` is not included per default** ([#5980](python-poetry/poetry#5980)). - **Outsource `poetry shell` into `poetry-plugin-shell`** ([#9763](python-poetry/poetry#9763)). - **Change the interface of `poetry add --optional` to require an extra the optional dependency is added to** ([#9135](python-poetry/poetry#9135)). - **Actually switch the directory when using `--directory`/`-C`** ([#9831](python-poetry/poetry#9831)). - **Drop support for Python 3.8** ([#9692](python-poetry/poetry#9692)). - Rename `experimental.system-git-client` to `experimental.system-git` ([#9787](python-poetry/poetry#9787), [#9795](python-poetry/poetry#9795)). - Replace `virtualenvs.prefer-active-python` by the inverse setting `virtualenvs.use-poetry-python` and prefer the active Python by default ([#9786](python-poetry/poetry#9786)). - Deprecate several fields in the `tool.poetry` section in favor of the respective fields in the `project` section in the `pyproject.toml` file ([#9135](python-poetry/poetry#9135)). - Deprecate `poetry install --sync` in favor of `poetry sync` ([#9801](python-poetry/poetry#9801)). - Upgrade the warning if the current project cannot be installed to an error ([#9333](python-poetry/poetry#9333)). - Remove special handling for `platformdirs 2.0` macOS config directory ([#8916](python-poetry/poetry#8916)). - Tweak PEP 517 builds ([#9094](python-poetry/poetry#9094)). - Use Poetry instead of pip to manage dependencies in isolated build environments ([#9168](python-poetry/poetry#9168), [#9227](python-poetry/poetry#9227)). - Trust empty `Requires-Dist` with modern metadata ([#9078](python-poetry/poetry#9078)). - Do PEP 517 builds instead of parsing `setup.py` to determine dependencies ([#9099](python-poetry/poetry#9099)). - Drop support for reading lock files prior version 1.0 (created with Poetry prior 1.1) ([#9345](python-poetry/poetry#9345)). - Default to `>=` instead of `^` for the Python requirement when initializing a new project ([#9558](python-poetry/poetry#9558)). - Limit `build-system` to the current major version of `poetry-core` when initializing a new project ([#9812](python-poetry/poetry#9812)). - Remove pip-based installation, i.e. `installer.modern-installation = false` ([#9392](python-poetry/poetry#9392)). - Remove `virtualenvs.options.no-setuptools` config option and never include `setuptools` per default ([#9331](python-poetry/poetry#9331)). - Rename exceptions to have an `Error` suffix ([#9705](python-poetry/poetry#9705)). - Remove deprecated CLI options and methods and revoke the deprecation of `--dev` ([#9732](python-poetry/poetry#9732)). - Ignore installed packages during dependency resolution ([#9851](python-poetry/poetry#9851)). - Improve the error message on upload failure ([#9701](python-poetry/poetry#9701)). - Improve the error message if the current project cannot be installed to include another root cause ([#9651](python-poetry/poetry#9651)). - Improve the output of `poetry show <package>` ([#9750](python-poetry/poetry#9750)). - Improve the error message for build errors ([#9870](python-poetry/poetry#9870)). - Improve the error message when trying to remove a package from a project without any dependencies ([#9918](python-poetry/poetry#9918)). - Drop the direct dependency on `crashtest` ([#9108](python-poetry/poetry#9108)). - Require `keyring>=23.3.1` ([#9167](python-poetry/poetry#9167)). - Require `build>=1.2.1` ([#9283](python-poetry/poetry#9283)). - Require `dulwich>=0.22.6` ([#9748](python-poetry/poetry#9748)). ##### Fixed - Fix an issue where git dependencies with extras could only be cloned if a branch was specified explicitly ([#7028](python-poetry/poetry#7028)). - Fix an issue where `poetry env remove` failed if `virtualenvs.in-project` was set to `true` ([#9118](python-poetry/poetry#9118)). - Fix an issue where locking packages with a digit at the end of the name and non-standard sdist names failed ([#9189](python-poetry/poetry#9189)). - Fix an issue where credentials where not passed when trying to download an URL dependency ([#9202](python-poetry/poetry#9202)). - Fix an issue where using uncommon group names with `poetry add` resulted in a broken `pyproject.toml` ([#9277](python-poetry/poetry#9277)). - Fix an issue where an inconsistent entry regarding the patch version of Python was kept in `envs.toml` ([#9286](python-poetry/poetry#9286)). - Fix an issue where relative paths were not resolved properly when using `poetry build --directory` ([#9433](python-poetry/poetry#9433)). - Fix an issue where unrequested extras were not uninstalled when running `poetry install` without an existing lock file ([#9345](python-poetry/poetry#9345)). - Fix an issue where the `poetry-check` pre-commit hook did not trigger if only `poetry.lock` has changed ([#9504](python-poetry/poetry#9504)). - Fix an issue where files (rather than directories) could not be added as single page source ([#9166](python-poetry/poetry#9166)). - Fix an issue where invalid constraints were generated when adding a package with a local version specifier ([#9603](python-poetry/poetry#9603)). - Fix several encoding warnings ([#8893](python-poetry/poetry#8893)). - Fix an issue where `virtualenvs.prefer-active-python` was not respected ([#9278](python-poetry/poetry#9278)). - Fix an issue where the line endings of the lock file were changed ([#9468](python-poetry/poetry#9468)). - Fix an issue where installing multiple dependencies from the same git repository failed sporadically due to a race condition ([#9658](python-poetry/poetry#9658)). - Fix an issue where installing multiple dependencies from forked monorepos failed sporadically due to a race condition ([#9723](python-poetry/poetry#9723)). - Fix an issue where an extra package was not installed if it is required by multiple extras ([#9700](python-poetry/poetry#9700)). - Fix an issue where a `direct_url.json` with vcs URLs not compliant with PEP 610 was written ([#9007](python-poetry/poetry#9007)). - Fix an issue where other files than wheels were recognized as wheels ([#9770](python-poetry/poetry#9770)). - Fix an issue where `installer.max-workers` was ignored for the implicit PyPI source ([#9815](python-poetry/poetry#9815)). - Fix an issue where local settings (from `poetry.toml`) were ignored for the implicit PyPI source ([#9816](python-poetry/poetry#9816)). - Fix an issue where different `dulwich` versions resulted in different hashes for a git dependency from a tag ([#9849](python-poetry/poetry#9849)). - Fix an issue where installing a yanked package with no dependencies failed with an `IndexError` ([#9505](python-poetry/poetry#9505)). - Fix an issue where a package could not be added from a source that required an empty password ([#9850](python-poetry/poetry#9850)). - Fix an issue where setting `allow-prereleases = false` still allowed pre-releases if no other solution was found ([#9798](python-poetry/poetry#9798)). - Fix an issue where the wrong environment was used for checking if an installed package is from system site packages ([#9861](python-poetry/poetry#9861)). - Fix an issue where build errors from builds to retrieve metadata information were hidden ([#9870](python-poetry/poetry#9870)). - Fix an issue where `poetry check` falsely reported that an invalid source "pypi" is referenced in dependencies ([#9475](python-poetry/poetry#9475)). - Fix an issue where `poetry install --sync` tried to uninstall system site packages if the virtual environment was created with `virtualenvs.options.system-site-packages = true` ([#9863](python-poetry/poetry#9863)). - Fix an issue where HTTP streaming requests were not closed properly when not completely consumed ([#9899](python-poetry/poetry#9899)). ##### Docs - Add information about getting test coverage in the contribution guide ([#9726](python-poetry/poetry#9726)). - Mention `pre-commit-update` as an alternative to `pre-commit autoupdate` ([#9716](python-poetry/poetry#9716)). - Improve the explanation of `exclude` and `include` ([#9734](python-poetry/poetry#9734)). - Add information about compatible release requirements, i.e. `~=` ([#9783](python-poetry/poetry#9783)). - Add documentation for using a build script to build extension modules ([#9864](python-poetry/poetry#9864)). ##### poetry-core ([`2.0.0`](https://github.com/python-poetry/poetry-core/releases/tag/2.0.0)) - Add support for non PEP440 compliant version in the `platform_release` marker ([#722](python-poetry/poetry-core#722)). - Add support for string comparisons with `in` / `not in` in generic constraints ([#722](python-poetry/poetry-core#722)). - Add support for script files that are generated by a build script ([#710](python-poetry/poetry-core#710)). - Add support for `SOURCE_DATE_EPOCH` when building packages ([#766](python-poetry/poetry-core#766), [#781](python-poetry/poetry-core#781)). - Create `METADATA` files with version 2.3 instead of 2.2 ([#707](python-poetry/poetry-core#707)). - Remove support for `x` in version constraints ([#770](python-poetry/poetry-core#770)). - Remove support for scripts with extras ([#708](python-poetry/poetry-core#708)). - Remove deprecated features and interfaces ([#702](python-poetry/poetry-core#702), [#769](python-poetry/poetry-core#769)). - Deprecate `tool.poetry.dev-dependencies` in favor of `tool.poetry.group.dev.dependencies` ([#754](python-poetry/poetry-core#754)). - Fix an issue where the `platlib` directory of the wrong Python was used ([#726](python-poetry/poetry-core#726)). - Fix an issue where building a wheel in a nested output directory results in an error ([#762](python-poetry/poetry-core#762)). - Fix an issue where `+` was not allowed in git URL paths ([#765](python-poetry/poetry-core#765)). - Fix an issue where the temporary directory was not cleaned up on error ([#775](python-poetry/poetry-core#775)). - Fix an issue where the regular expression for author names was too restrictive ([#517](python-poetry/poetry-core#517)). - Fix an issue where basic auth http(s) credentials could not be parsed ([#791](python-poetry/poetry-core#791)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/1319 Co-authored-by: renovate-bot <[email protected]> Co-committed-by: renovate-bot <[email protected]>

fix reduce_by_python_constraint

a705a2c

This fixes a bug that caused incorrect markers to be written into the lock file. See poetry-plugin-export#319.

sourcery-ai bot reviewed Jan 24, 2025

View reviewed changes

abn approved these changes Jan 24, 2025

View reviewed changes

abn merged commit 4e7c384 into python-poetry:main Jan 24, 2025
18 checks passed

radoering mentioned this pull request Jan 24, 2025

Export saves incorrect markers in 1.9.0 python-poetry/poetry-plugin-export#319

Closed

This was referenced Feb 9, 2025

release: bump version to 2.1.0 #834

Merged

release: bump version to 2.1.0 python-poetry/poetry#10154

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix `reduce_by_python_constraint` #824

fix `reduce_by_python_constraint` #824

radoering commented Jan 24, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 24, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

fix reduce_by_python_constraint #824

fix reduce_by_python_constraint #824

Conversation

radoering commented Jan 24, 2025 • edited by sourcery-ai bot Loading

Summary by Sourcery

sourcery-ai bot commented Jan 24, 2025 • edited Loading

Reviewer's Guide by Sourcery

Sequence diagram for reduce_by_python_constraint marker handling

Class diagram for marker handling

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

fix `reduce_by_python_constraint` #824

fix `reduce_by_python_constraint` #824

radoering commented Jan 24, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 24, 2025 •

edited

Loading