feat(python): use findpython

[abn]

With this change Poetry will use findpython for Python version discovery. This helps remove Poetry's own custom "best effort" Python version discovery and hopefully also resolve a lot of issues related to the discovery of available Python versions in a given environment.

This change largely focuses on the Python Manager and not the Environment Manager. The latter could also be improved once this has landed.

Testing

Using pipx

pipx install --suffix=@10097 'poetry @ git+https://github.com/python-poetry/poetry.git@refs/pull/10097/head'
alias poetry=poetry@10097
poetry new foobar
cd foobar
poetry install
poetry env use 3.13

Using a container (podman | docker)

podman run --rm -i --entrypoint bash docker.io/python:latest <<EOF
set -xe 
python -m pip install --disable-pip-version-check -q git+https://github.com/python-poetry/poetry.git@refs/pull/10097/head
poetry new foobar
cd foobar
poetry env use 3.13
EOF

Summary by Sourcery

Tests:

• Use mocked Python versions in tests.

Summary by Sourcery

Tests:

• Use mocked Python versions in tests.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces the usage of the findpython library for Python version discovery, replacing Poetry's custom implementation. This change primarily affects the Python Manager, aiming to improve the accuracy and reliability of Python version detection.

Sequence diagram for Python version discovery process

sequenceDiagram
    participant Client
    participant Python
    participant FindPython
    participant ShutilWhichProvider

    Client->>Python: get_preferred_python(config, io)
    alt use-poetry-python is false
        Python->>Python: get_active_python()
        Python->>ShutilWhichProvider: find_pythons()
        ShutilWhichProvider-->>Python: python_list
        alt python found
            Python-->>Client: active_python
        else no python found
            Python->>FindPython: find('python')
            FindPython-->>Python: python_version
            Python-->>Client: python_instance
        end
    else use poetry python
        Python->>Python: get_system_python()
        Python-->>Client: system_python
    end

Loading

Class diagram for Python version management changes

classDiagram
    class Python {
        -_python: PythonVersion
        +executable: Path
        +version: Version
        +patch_version: Version
        +minor_version: Version
        +get_active_python()
        +from_executable(path)
        +get_system_python()
        +get_by_name(python_name)
        +get_preferred_python(config, io)
        +get_compatible_python(poetry, io)
    }

    class ShutilWhichPythonProvider {
        +create()
        +find_pythons()
    }

    class PythonVersionError {
    }

    class PythonVersionNotFoundError {
        +__init__(expected: str)
    }

    class NoCompatiblePythonVersionError {
        +__init__(expected: str, given: str)
    }

    class InvalidCurrentPythonVersionError {
        +__init__(expected: str, given: str)
    }

    PythonVersionNotFoundError --|> PythonVersionError
    NoCompatiblePythonVersionError --|> PythonVersionError
    InvalidCurrentPythonVersionError --|> PythonVersionError
    ShutilWhichPythonProvider --|> BaseProvider

    note for Python "Uses findpython library for version discovery"

Loading

File-Level Changes

Change	Details	Files
Replaced custom Python discovery logic with findpython library.	Removed custom Python version detection logic. Added findpython as a dependency. Implemented findpython to discover Python versions. Updated Python manager to use findpython. Added mocks for findpython in tests. Adjusted tests to use mocked Python versions. Removed usage of shutil.which for python discovery. Removed usage of subprocess.check_output for python discovery.	src/poetry/utils/env/python/manager.py src/poetry/utils/env/python/exceptions.py src/poetry/utils/env/python/providers.py src/poetry/utils/env/python/__init__.py src/poetry/utils/env/env_manager.py tests/utils/test_python_manager.py tests/utils/env/test_env_manager.py tests/conftest.py tests/console/commands/test_new.py tests/console/commands/test_init.py tests/console/commands/env/test_use.py tests/types.py
Added new fixtures for mocking findpython.	Added mocked_pythons fixture to provide a list of mocked Python versions. Added mocked_pythons_version_map fixture to provide a map of mocked Python versions. Added mock_findpython_find fixture to mock the findpython.find function. Added mock_findpython_find_all fixture to mock the findpython.find_all function. Added mocked_python_register fixture to register mocked Python versions. Added with_mocked_findpython fixture to enable mocking of findpython. Added without_mocked_findpython fixture to disable mocking of findpython.	tests/conftest.py
Refactored tests to use mocked Python versions.	Updated tests to use mocked_pythons fixture. Updated tests to use mock_findpython_find fixture. Updated tests to use mock_findpython_find_all fixture. Updated tests to use mocked_python_register fixture. Removed direct calls to subprocess.check_output. Removed direct calls to shutil.which.	tests/utils/test_python_manager.py tests/utils/env/test_env_manager.py tests/console/commands/test_new.py tests/console/commands/test_init.py tests/console/commands/env/test_use.py
Introduced Python class to encapsulate Python version information.	Created Python class to represent a Python executable and its version. Added methods to get active, system, and compatible Python versions. Moved Python related exceptions to src/poetry/utils/env/python/exceptions.py. Created ShutilWhichPythonProvider to find python executables in the path.	src/poetry/utils/env/python/manager.py src/poetry/utils/env/python/exceptions.py src/poetry/utils/env/python/providers.py src/poetry/utils/env/python/__init__.py
Updated EnvManager to use the new Python class.	Modified EnvManager to use the Python class for Python version detection. Updated EnvManager to use the Python class for creating virtual environments. Removed direct calls to findpython from EnvManager.	src/poetry/utils/env/env_manager.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @abn - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[abn]

@sourcery-ai review

[sourcery-ai]

Hey @abn - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[abn]

@sourcery-ai review

[sourcery-ai]

Hey @abn - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[abn]

@sourcery-ai review

[sourcery-ai]

Hey @abn - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}