Feature/remove ultralytics #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
+ Coverage 62.29% 65.60% +3.30%
===========================================
Files 5 7 +2
Lines 183 250 +67
===========================================
+ Hits 114 164 +50
- Misses 69 86 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
frgfm
reviewed
Jul 27, 2022
|
|
||
| y = self.session.run(["output"], {"images": x.numpy()})[0] | ||
|
|
||
| output = non_max_suppression(torch.tensor(y), self.conf_thres)[0].numpy() |
There was a problem hiding this comment.
do we need to convert it back to a pytorch tensor?
Can't we do it with numpy? I'd suggest implementing the utils in pure numpy to get rid of PyTorch & torchvision. (onnx works with numpy either way, not Pytorch tensors)
|
This is not relevant anymore after #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to get rid of the ultralytics repo and all its dependencies with a class that allows to perform inference directly from the onnx model