-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Cleaned pyroengine and refactored project #101
Conversation
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 62.29% 67.90% +5.60%
==========================================
Files 5 3 -2
Lines 183 162 -21
==========================================
- Hits 114 110 -4
+ Misses 69 52 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fg, thanks so much for this PR! Globally LGTM. Several sticking points though:
- This PR must be merge on develop and not main directly
- CIs must run on main & develop
To discuss
We never used the felix code to monitor the pi's but I think it would be nice to do so, I don't know if it's a good idea to delete it
NB: It would be better to use a fork
All good, codebase should be clean :) |
Thanks for the update, what about these comments ? |
Oops I didnt see the last part:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces the following changes:
pyroengine
pi_utils
(not used)pyroengine.engine.engine
topyroengine.core
pyroengine.vision
withClassifier
which holds the ONNX modeltests
docs
server
folderrunner
assrc
src
by implementingReolinkCamera
andSystemController
pyproject.toml
Makefile
Basically, for the wrapper (orginially
runner
, nowsrc
), the only difference is:For reviewers, I highly suggest to check the modifications by commit, it might be easier 😅