fix: Fixed package versioning of databases #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgfm
added
type: fix
frgfm
requested review from
florianriche,
jean-pasquier,
fe51 and
martin1tab
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 19 19
Lines 551 551
=======================================
Hits 495 495
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
florianriche
approved these changes
Nov 17, 2020
fe51
approved these changes
Nov 17, 2020
|
@florianriche not specifically, they seem to have change psycopg2 dependency in encode/databases#256 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #38, tests were failing apparently because of a missing
psycopg2dependency. So I checked the last previous PR successfully building which is #37:The build of 37 (https://github.com/pyronear/pyro-api/pull/37/checks?check_run_id=1408361256) installs
databasesv0.4.0 while the other (https://github.com/pyronear/pyro-api/pull/38/checks?check_run_id=1411729940) installs version 0.4.1. I checked locally and adding an upper bound constraint fixes the issue.Any feedback is welcome!