Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove psycopg2 and pymysql from the direct dependencies #256

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Remove psycopg2 and pymysql from the direct dependencies #256

merged 1 commit into from
Nov 16, 2020

Conversation

vmarkovtsev
Copy link
Contributor

@vmarkovtsev vmarkovtsev commented Oct 21, 2020 •
edited
Loading

Related to #204

This should fix my own builds and I guess other people's too.

@vmarkovtsev
Copy link
Contributor Author

cc @retnikt

@daviskirk
Copy link

Haven't upgraded but I know that the binary/non-binary problem has gotten me before, especially when trying to explain to others what they have to do to not get errors when installing stuff. So just having everyone decide what they want as suggested here is probably better.

@pythoninja pythoninja mentioned this pull request Oct 21, 2020
Closed
@subdavis
Copy link

subdavis commented Oct 22, 2020 •
edited
Loading

Just to be clear, this broke build for everyone who uses databases[postgresql] and psycopg2-binary, right?

I'm surprised there isn't more voting/commenting on this thread, and no back-refs from other projects to this issue.

For anyone playing along at home, "databases[postgresql]<0.4.0", should temporarily fix your build errors.

Thanks for all the hard work, btw :)

@vmarkovtsev
Copy link
Contributor Author

Version pinning ftw, yes. There is another option:

databases==0.4.0
asyncpg==0.21.0

@polyrand
Copy link

Yes, this broke my builds too. I think the option given by Tom: #204 (comment) is very reasonable. Thanks for the fast response and the work done on this!

@vmarkovtsev
Copy link
Contributor Author

@encode/maintainers can please somebody approve this deal breaking fix.

@rsommerard
Copy link

rsommerard commented Nov 16, 2020 •
edited
Loading

I'm having this issue too, please consider this PR.

florimondmanca
florimondmanca approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good — let's consider a 0.5.0 bump perhaps. (Or, alternatively, let's skip bumping versions in this PR, and issue a proper release PR later when we're ready to issue 0.5.0.)

CHANGELOG.md
Comment on lines +7 to +12
## 0.4.1 (October 21st, 2020)

### Fixed

* Remove package dependency on the synchronous DB drivers (#256)

Copy link
Member

@florimondmanca florimondmanca Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we okay with bumping to 0.5.0? I think this qualifies as an entry for a "Changed" section, rather than "Fixed". That way people that are currently pinned to 0.4.* will be fine.

I'm not sure I understood the broken build issue with these direct dependencies, though (edit: I assume that's related to 3.9 and the lack of wheels?) but I think sticking closer to SemVer is a good idea here?

Copy link
Contributor Author

@vmarkovtsev vmarkovtsev Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have literally no other features to release rather than the broken package installation of 0.4.0 😂 And it was planned for 0.4.0 long before I became a maintainer, so I honestly just overlooked this PR.

Copy link
Contributor Author

@vmarkovtsev vmarkovtsev Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, we have to bump the version, otherwise it does not deploy to pypi and many people continue suffering.

Thanks for the approval, I will carry on with the release now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@vmarkovtsev vmarkovtsev merged commit 5b60ba8 into encode:master Nov 16, 2020
@vmarkovtsev
Copy link
Contributor Author

https://github.com/encode/databases/releases/tag/0.4.1

florimondmanca
florimondmanca reviewed Nov 16, 2020
View reviewed changes
CHANGELOG.md
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## 0.4.1 (October 21st, 2020)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, the release date is a bit out of sync now. :-)

Should be:

## 0.4.1 (November 16th, 2020)

@florimondmanca florimondmanca mentioned this pull request Nov 16, 2020
Merged
@frgfm frgfm mentioned this pull request Nov 17, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vmarkovtsev @daviskirk @subdavis @polyrand @rsommerard @florimondmanca