Consolidate --path parsing into cmdoptions.py
#6600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
skip news
cjerdonek
approved these changes
Jun 13, 2019
src/pip/_internal/commands/freeze.py
Outdated
| @@ -75,6 +70,7 @@ def __init__(self, *args, **kw): | |||
| action='store_true', | |||
| help='Exclude editable package from output.') | |||
|
|
|||
| self.cmd_opts.add_option(cmdoptions.list_path()) | |||
There was a problem hiding this comment.
Does where add_option() is called control the order of display when invoking --help? If so, would it make sense to group --path after --local and --user like it was before (since --path is mutually exclusive with those other options)?
There was a problem hiding this comment.
You are totally right. Fixed.
lkollar
force-pushed
the
consolidate-path-opt-parsing
branch
from
65d0f6a to
ff47ff8
Compare
This option is used both in the `freeze` and `list` commands. The code to parse the option and validate that it's not used with incompatible arguments should be done in one place.
lkollar
force-pushed
the
consolidate-path-opt-parsing
branch
from
ff47ff8 to
246130c
Compare
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is used both in the
freezeandlistcommands. The code to parse the option and validate that it's not used with incompatible arguments should be done in one place.This addresses @cjerdonek's comment in #6580.