Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --path option to pip list #6580

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Add --path option to pip list #6580

merged 1 commit into from
Jun 12, 2019

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented Jun 7, 2019 •
edited
Loading

This makes pip list consistent with pip freeze which also supports listing packages in arbitrary file paths.

Closes: #6551

@lkollar lkollar changed the title Add --path option to pip list WIP: Add --path option to pip list Jun 9, 2019
@lkollar
Add --path option to pip list
35a6fc1 
This makes `pip list` consistent with `pip freeze` which also supports
listing packages in arbitrary file paths.
@lkollar lkollar changed the title WIP: Add --path option to pip list Add --path option to pip list Jun 9, 2019
pradyunsg
pradyunsg reviewed Jun 12, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pradyunsg
Copy link
Member

/cc @xavfernandez since he'd originally suggested this. :)

@xavfernandez xavfernandez merged commit a240a98 into pypa:master Jun 12, 2019
@xavfernandez
Copy link
Member

Thanks @lkollar 👍

@cjerdonek
Copy link
Member

Thanks for doing this. I noticed though that the option definition and option checking added in list.py is the same as what was added to freeze.py in PR #6450. I think it would be helpful if those two files used the same code (can be placed in cmdoptions.py). Otherwise, it makes it harder to simplify / maintain the command code.

@lkollar
Copy link
Contributor Author

lkollar commented Jun 12, 2019

That is a very good point @cjerdonek. I will submit a new PR to consolidate the code into cmdoptions.py.

@lkollar lkollar mentioned this pull request Jun 12, 2019
Merged
@cjerdonek
Copy link
Member

Great, thank you, @lkollar! I'm happy to review if others don't get to it before me.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List packages under a given path with pip list
4 participants
@lkollar @pradyunsg @xavfernandez @cjerdonek