Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging error after #163 #211

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Fix packaging error after #163 #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ff492
Fix bad merge
ryanking13 Feb 20, 2025
40bbdd3
Don't load packaging when loading micropip
ryanking13 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions micropip/package_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
List,
)

from packaging.markers import default_environment

from . import _mock_package, package_index
from ._compat import CompatibilityLayer, compatibility_layer
from ._utils import get_files_in_distribution, get_root
from ._vendored.packaging.src.packaging.markers import default_environment
from .constants import FAQ_URLS
from .freeze import freeze_lockfile
from .logging import setup_logging
Expand Down
1 change: 0 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ def selenium_standalone_micropip(selenium_standalone, wheel_path):
selenium_standalone.run_js(
f"""
await pyodide.loadPackage("{base_url + wheel_file.name}");
await pyodide.loadPackage(["packaging"]);
pyodide.runPython("import micropip");
"""
)
Expand Down