Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging error after #163 #211

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

ryanking13
Copy link
Member

There was a bad merge

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry for missing that and thanks for catching it, @ryanking13!

@ryanking13
Copy link
Member Author

It was my bad 😅. We were always load packaging when using selenium_standalone_micropip fixture (which was also fixed in this PR) so it was not detected.

@ryanking13 ryanking13 merged commit 71a87c1 into pyodide:main Feb 20, 2025
7 checks passed
@ryanking13 ryanking13 deleted the bad-merge-packaging branch February 20, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants