Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify implementation of tile #1187

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 3, 2025

Removes obscure ndim kwarg that was needed before we had static shapes.


📚 Documentation preview 📚: https://pytensor--1187.org.readthedocs.build/en/1187/

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (884dee9) to head (d37cbb8).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
- Coverage   82.29%   82.29%   -0.01%     
==========================================
  Files         186      186              
  Lines       48039    48034       -5     
  Branches     8632     8629       -3     
==========================================
- Hits        39533    39528       -5     
  Misses       6348     6348              
  Partials     2158     2158              
Files with missing lines Coverage Δ
pytensor/tensor/basic.py 91.37% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@Armavica Armavica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, I made a few minor comments

pytensor/tensor/basic.py Outdated Show resolved Hide resolved
tests/tensor/test_basic.py Outdated Show resolved Hide resolved
pytensor/tensor/basic.py Outdated Show resolved Hide resolved
pytensor/tensor/basic.py Show resolved Hide resolved
pytensor/tensor/basic.py Outdated Show resolved Hide resolved
tests/tensor/test_basic.py Outdated Show resolved Hide resolved
tests/tensor/test_basic.py Outdated Show resolved Hide resolved
Deprecate obscure ndim kwarg
@ricardoV94 ricardoV94 merged commit 4ac1e63 into pymc-devs:main Feb 4, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants