Add initial distribution parameter types #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5315 +/- ##
==========================================
- Coverage 80.23% 79.43% -0.80%
==========================================
Files 89 89
Lines 14856 14857 +1
==========================================
- Hits 11919 11801 -118
- Misses 2937 3056 +119
|
ricardoV94
reviewed
Jan 6, 2022
ricardoV94
requested changes
Jan 7, 2022
canyon289
force-pushed
the
update_dist_parameter_types
branch
from
d6f63c4 to
d8f5a4d
Compare
canyon289
commented
Jan 8, 2022
| sd: Optional[Union[float, np.ndarray]] = None, | ||
| lower: Optional[Union[float, np.ndarray]] = None, | ||
| upper: Optional[Union[float, np.ndarray]] = None, | ||
| mu: Optional[DIST_PARAMETER_TYPES] = None, |
There was a problem hiding this comment.
Thanks for previous comment @ricardoV94. Hows it looking now?
One question, are dist parameter always optional? If so I can move the optional flag to the definition
There was a problem hiding this comment.
No they are not always optional. Most times they are required actually
There was a problem hiding this comment.
🎉 can we merge? Ill create an issue ticket for data umbrella sprint too have others add to the other parameters.
Thanks Ricardo
canyon289
force-pushed
the
update_dist_parameter_types
branch
from
d8f5a4d to
66deb25
Compare
ricardoV94
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comment #5298 (comment)
Let me know if I got it right @ricardoV94