Add Type Hints to distribution parameters

[canyon289]

Add type hints to distribution parameters as demonstrated by this PR.
#5315

If multiple people are interested in this we split this up by module

• Discrete distributions - Assigned to @nvasilevv

[nvasilevv]

Hi @canyon289, if you do not mind, I can pick that?

[canyon289]

@nvasilevv sure thing! Do you know which file(s) you want to start with? I'll open up a subissue for you so this can be address in parts

[nvasilevv]

Well, I do not have preferences. I have a brief question on #5315. I saw that no type hints were used here. Any reason why this is the case? There are other instances within the file where such changes were skipped, but looks like such are possible. Was this out of the scope of the PR or is there something I am missing? Thanks

[mjhajharia]

hi @nvasilevv, thanks for volunteering to contribute! did you open a pull request? if not, can you choose a submodule so we can create more issues and split up the work, it would be easier for you to contribute and us to manage the workflow that way! let me know if you need help

[nvasilevv]

Hi @mjhajharia, sorry for the late reply. I can start with the discrete distributions if that is ok with everyone.

[canyon289]

@nvasilevv discrete distributions sounds great. I'll add a note to the issue to indicate your assignment. Thanks for your continued interest

[purna135]

Hello, I'd like to work on this but don't know where to begin; could you possibly point me in the right direction?
Thanks

[hectormz]

@canyon289 @mjhajharia I was looking through what remains to be done for this. Are you trying to update the type hints for all def dist() with current types of:

• np.ndarray or
• int or
• float or
• TensorVariable

?

[canyon289]

hey hector, all the ones that are applicable!

[soma2000-lang]

@canyon289 Working on the mixture

[iykat]

@canyon289 working on continuous.

[canyon289]

Thanks!

[johanbog]

As the PR for discrete distributions was never merged, I'm picking that up now.

[fergur]

I'll take a look at this one. (hackathon)