Important miscellaneous v4 updates
#4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case this influences the re-implementation of missing values I would call your attention to this existing issue in V3: #4488 (comment) Basically imputed missing values are not being automatically transformed in V3 which causes issues during sampling/ MAP estimation. |
OK, we can change that here. I'm only refactoring things right now in an attempt to make the missing value mechanics more straightforward, but we can add that as a requirement—and as a test—to this new implementation. |
brandonwillard
force-pushed
the
fix-missing-values
branch
6 times, most recently
from
ace9f6f to
205fd15
Compare
brandonwillard
force-pushed
the
fix-missing-values
branch
2 times, most recently
from
285c61c to
96a9eca
Compare
brandonwillard
force-pushed
the
fix-missing-values
branch
from
96a9eca to
919289b
Compare
brandonwillard
changed the title
v4v4 updates
brandonwillard
force-pushed
the
fix-missing-values
branch
2 times, most recently
from
d7c68fe to
309295a
Compare
brandonwillard
force-pushed
the
fix-missing-values
branch
from
309295a to
ce2c6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements missing values inv4.Too many related fixes were needed before finishing the missing value support re-implementation, and, since a few are critical fixes, I'm going to change the topic of this PR and merge. I'll add the missing values re-implementation in a follow-up PR shortly.