Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of *.tag.test_value and replace with a new initial value framework #4567

Closed
brandonwillard opened this issue Mar 24, 2021 · 6 comments

Comments

@brandonwillard
Copy link
Contributor

We need to set up a framework for setting and getting initial values for a model; one that doesn't rely on Aesara's test values.

In many cases, this may be as simple as renaming parts of the existing API (e.g. Model.test_point to Model.initial_point, Model.check_test_point to Model.check_initial_point, change the testval Distribution argument to initial_value, etc.), but, in some cases, we'll need to add new variables and logic.

Specifically, it seems like we'll need to store the initial values in the Model object and, in multiple places, obtain those values from a Model object.

@farhanreynaldo
Copy link
Contributor

I would like to take on this issue. Should I do the pull request on v4 branch? Would also really appreciate feedback and your help on this issue

@brandonwillard
Copy link
Contributor Author

You might need to wait until #4577 goes through, because it looks like I'll need to implement some of this for other reasons.

@farhanreynaldo
Copy link
Contributor

Sure thing, I will start working when it's merged.

@ricardoV94
Copy link
Member

ricardoV94 commented May 29, 2021

For whomever takes this one, the Flat and HalfFlat are examples of pymc3 "distributions" that require special care because they cannot be sampled from directly, and as such an initial value has to be chosen some other way.

@ricardoV94
Copy link
Member

@brandonwillard can we close this one?

@twiecki
Copy link
Member

twiecki commented Aug 13, 2021

Sounds like this is implemented now.

@twiecki twiecki closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants