-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all uses of *.tag.test_value
and replace with a new initial value framework
#4567
Comments
I would like to take on this issue. Should I do the pull request on |
You might need to wait until #4577 goes through, because it looks like I'll need to implement some of this for other reasons. |
Sure thing, I will start working when it's merged. |
For whomever takes this one, the |
@brandonwillard can we close this one? |
Sounds like this is implemented now. |
We need to set up a framework for setting and getting initial values for a model; one that doesn't rely on Aesara's test values.
In many cases, this may be as simple as renaming parts of the existing API (e.g.
Model.test_point
toModel.initial_point
,Model.check_test_point
toModel.check_initial_point
, change thetestval
Distribution
argument toinitial_value
, etc.), but, in some cases, we'll need to add new variables and logic.Specifically, it seems like we'll need to store the initial values in the
Model
object and, in multiple places, obtain those values from aModel
object.The text was updated successfully, but these errors were encountered: