Modify zarr chunking as suggested in #4496 #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexamici
requested changes
Dec 3, 2020
xarray/tests/test_backends.py
Outdated
| @@ -2172,6 +2179,10 @@ def test_open_zarr_use_cftime(self): | |||
| ds_b = xr.open_zarr(store_target, consolidated=True, use_cftime=True) | |||
| assert xr.coding.times.contains_cftime_datetimes(ds_b.time) | |||
|
|
|||
| @requires_dask | |||
There was a problem hiding this comment.
Use xfail instead, because this is a real limitation with the current implementation.
shoyer
reviewed
Dec 3, 2020
alexamici
approved these changes
Dec 9, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4595
The changes involve only
open_dataset(..., engine=zarr)(and marginallyopen_zarr), in particular,_get_chunkshas been modified to fit #4496 (comment) option 1 chunking behaviour and align open_dataset chunking withdataset.chunk:autoit uses dask auto-chunking (if a preferred_chunking is defined, dask will take it into account as done indataset.chunk)-1it uses dask but no chunking.{}it uses the backend encoded chunks (when available) for on-disk data (xr.open_dataset) and the current chunking for already opened datasets (ds.chunk)Add some test
isort . && black . && mypy . && flake8whats-new.rst