WIP: Chunking refactor #4595
Closed
WIP: Chunking refactor #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Nov 19, 2020
xarray/core/dataset.py
Outdated
| @@ -1855,17 +1907,22 @@ def chunk( | |||
| ------- | |||
| chunked : xarray.Dataset | |||
| """ | |||
| if chunks is None: | |||
There was a problem hiding this comment.
reminder to update the docstring here
revert style fix
This was referenced Dec 1, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work aims to harmonize the way zarr deals with chunking to have similar behavior for all other backends and unify the code.
Most of the changes involve the new API, apiv2.py, except for some changes in the code that has been added with the merge of #4187.
main changes:
apiv2.dataset_from_backend_datasetfunction._get_chunksfromzarrtodataset._get_chunksto fit Flexible backends - Harmonise zarr chunking with other backends chunking #4496 (comment) option 1 chunking behaviuords.chunk(..., chunk=None)nedded separate pull request for the following missing points:
standardize the key in encodings to define the on-disk chunks:
chunksizesadd a specific key in encodings for preferred chunking (currently it is used
chunks)Related Flexible backends - Harmonise zarr chunking with other backends chunking #4496
Tests added
Passes
isort . && black . && mypy . && flake8User visible changes (including notable bug fixes) are documented in
whats-new.rstNew functions/methods are listed in
api.rst