Fix errors in the test suite due to pytest warning changes #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing CI failures for some builds. This is really a pytest bug (pytest-dev/pytest#2430), but working around this on our end is easy enough (and cleans things up a little).
4 tasks
gidden
reviewed
May 24, 2017
xarray/tests/__init__.py
Outdated
| yield | ||
| assert len(w) > 0 | ||
| assert any(message in str(wi.message) for wi in w) | ||
| assert len(w) > 0 |
There was a problem hiding this comment.
is the change in indentation intentional? I would expect w to leave scope.
There was a problem hiding this comment.
Yes, this was intentional. Python with blocks don't define scopes for variables, so w is still defined outside the block. In this case, the with block only indicates where warnings should be caught.
|
TIL, thanks!
…On Wed, May 24, 2017 at 10:34 AM, Stephan Hoyer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In xarray/tests/__init__.py
<#1423 (comment)>:
> yield
- assert len(w) > 0
- assert any(message in str(wi.message) for wi in w)
+ assert len(w) > 0
Yes, this was intentional. Python with blocks don't define scopes for
variables, so w is still defined outside the block. In this case, the with
block only indicates where warnings should be caught.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1423 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABVAESisUh7dTNsp3l4OryHoCGuJPb2gks5r8-uugaJpZM4Nkq_Z>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing CI failures for some builds.
This is really a pytest bug (pytest-dev/pytest#2430), but working around this on our end is easy enough (and cleans things up a little).
git diff upstream/master | flake8 --diff