attempt to fix #497 #1382
Merged
attempt to fix #497 #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like an improvement over what we have now. So yes, please do clean it up and we can merge it! |
|
ok, should be cleaned up and ready to go @shoyer |
… suggestions before rethrowing
gidden
force-pushed
the
nc4-read
branch
2 times, most recently
from
1156d6e to
ae0cbe3
Compare
|
hey @shoyer, this is failing one each of a dataset and dataarray test. I am not sure why, could you please assist? thanks! |
|
sounds good!
…On Wed, May 24, 2017 at 10:01 AM, Stephan Hoyer ***@***.***> wrote:
@gidden <https://github.com/gidden> this isn't you -- pytest broke us
(I'll merge #1423 <#1423> with a fix
shortly)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1382 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABVAEb3B2kY6tXD2hMAljEAnWTFf41tmks5r8-PGgaJpZM4NFWoG>
.
|
|
Thanks @gidden! |
|
Very welcome, @shoyer!
…On Thu, May 25, 2017 at 4:06 AM, Stephan Hoyer ***@***.***> wrote:
Thanks @gidden <https://github.com/gidden>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1382 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABVAEazXapfuaOUBd8lK87IQFhwBoBTSks5r9OIagaJpZM4NFWoG>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThis is a suggested fix to #497. I am happy to clean it up, etc., if the maintainers think it is worthwhile.