-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pybop.MAP
with pybop.LogPosterior
#483
Conversation
… initial notebook, updts tests and bugfixes, adds __repr__ to parameters, refactors logpdfS1 for JointPrior
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #483 +/- ##
===========================================
+ Coverage 99.01% 99.03% +0.02%
===========================================
Files 52 52
Lines 3555 3527 -28
===========================================
- Hits 3520 3493 -27
+ Misses 35 34 -1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # examples/notebooks/comparing_cost_functions.ipynb # examples/notebooks/cost-compute-methods.ipynb # examples/notebooks/multi_model_identification.ipynb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @BradyPlanden, a few suggestions below:
I would merge, but are we merging or squash merging? |
I'm happy with either. I've been merging as is, with squashes close to a release for cherry picking, or if the branch commits are quite noisy. |
Description
pybop.MAP
withpybop.LogPosterior
,Issue reference
Fixes #459
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.